feat: 통계 진입 시 보고있던 월의 통계 화면으로 띄워주기 #353
Merged
Merged
Conversation
added 9 commits
June 4, 2026 19:16
- emptyView y축 가운데 정렬 - 첫 목표 이후 화살표 제거
Member
|
@coderabbitai summary |
clxxrlove
approved these changes
Jun 10, 2026
| /// let state = StatsDetailReducer.State(goalId: 1) | ||
| /// ``` | ||
| public init(goalId: Int64) { | ||
| public init(goalId: Int64, calendarDate: TXCalendarDate?) { |
Member
There was a problem hiding this comment.
사소한 포인트인데, calenderDate라는 매개변수가 무슨 뜻인가 싶더라구
그래서 생각해보니 initialMonth 정도 되겠구나 싶은걸 알았는데,
그럼 시작 월이라던지, 날짜를 굳이 지정할 생각이 없으면 nil이 가능하게 기본값을 지정해주는 것도 좋을 듯?
Contributor
Author
There was a problem hiding this comment.
말한대로 네이밍 좀 헷갈리는 거 같아서 initialMonth로 바꿀게
그리고 코드 다시 보니까 nil 전달하는 경우가 없어서 옵셔널도 빼고 initialMonth를 필수 주입하도록 바꿀게
근데 기본값으로 지정할 경우 호출부에서 initialMonth를 주입해야하는데 실수로 빼먹을 경우가 있을 수 있으니 기본값 지정은 안하고 필수 주입하는거로 고칠게!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
📙 작업 내역
🎨 스크린샷 또는 시연 영상 (선택)
Simulator.Screen.Recording.-.iPhone.17.Pro.26.-.2026-06-08.at.18.48.16.mov