Skip to content

fix: 수정하기 버그 수정 - [TWI-113]#340

Merged
jihun32 merged 4 commits into
developfrom
fix/#330/TWI-113
Jun 4, 2026
Merged

fix: 수정하기 버그 수정 - [TWI-113]#340
jihun32 merged 4 commits into
developfrom
fix/#330/TWI-113

Conversation

@jihun32

@jihun32 jihun32 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

🔗 관련 이슈

📙 작업 내역

  • 수정간 카드 스와이프 되는 이슈 수정
  • 상대방, 나 둘 다 코멘트 있을 때 수정 안되는 이슈 수정
  • 인증샷 상세에서 수정할 때 키보드 올라오면서 View 전체 밀리는거 코멘트 컴포넌트만 밀리도록 수정

🎨 스크린샷 또는 시연 영상 (선택)

2026-06-01.8.20.59.mov

@linear-code

linear-code Bot commented Jun 1, 2026

Copy link
Copy Markdown

TWI-113

@clxxrlove

Copy link
Copy Markdown
Member

@coderabbitai summary

@github-actions github-actions Bot added the D-3 label Jun 1, 2026
@github-actions github-actions Bot requested a review from clxxrlove June 1, 2026 11:23
@jihun32 jihun32 changed the title Fix/#330/twi 113 fix: 수정하기 버그 수정 - [TWI-113] Jun 1, 2026
@clxxrlove clxxrlove added the fix label Jun 1, 2026
@github-actions github-actions Bot added D-2 and removed D-3 labels Jun 2, 2026

@clxxrlove clxxrlove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어~~ 👍

Comment on lines +419 to +420
let posX = rectFrame.minX - rootFrame.minX
let posY = rectFrame.minY - rootFrame.minY

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rectFrame이 현재 front 카드 전용 frame이 아니라 공유 state로 관리되고 있는데, completed card가 양쪽 카드/hidden card까지 레이아웃되는 상황에서는 마지막으로 측정된 카드 frame이 들어와 댓글 오버레이가 현재 보이는 카드가 아닌 위치에 붙거나 튈 수 있을듯.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#346 443c625
커밋에서 해당 내용 반영 되있으니 함 확인해보고 이건 머지 해놓을게

@github-actions github-actions Bot added D-1 and removed D-2 labels Jun 3, 2026
@jihun32 jihun32 closed this Jun 4, 2026
@jihun32 jihun32 reopened this Jun 4, 2026
@jihun32 jihun32 merged commit 903c3f2 into develop Jun 4, 2026
11 checks passed
@jihun32 jihun32 deleted the fix/#330/TWI-113 branch June 4, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants