Default validator relative error#427
Merged
gkreitz merged 2 commits intoMay 25, 2026
Merged
Conversation
gkreitz
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For context, the current output validator doesn't list the relative error, which can be frustrating:
The relative error is "obviously" almost good enough, but too far away. Exactly how far away? I would prefer to not have to pull up a calculator to find.
Now that the code is already being touched, I propose we do the following changes:
Example output:
I still don't think it's perfect: showing a negative tolerance is slightly confusing. However, fixing the printing for that in a non-hacky way would likely require a minor rewrite, which I feel is not worth it.