Skip to content

Fixes #38577 - Fix snapshots - #11441

Merged
jeremylenz merged 2 commits into
Katello:masterfrom
jeremylenz:38577-snapshots-scalprum
Jul 16, 2025
Merged

Fixes #38577 - Fix snapshots#11441
jeremylenz merged 2 commits into
Katello:masterfrom
jeremylenz:38577-snapshots-scalprum

Conversation

@jeremylenz

@jeremylenz jeremylenz commented Jul 14, 2025

Copy link
Copy Markdown
Member

What are the changes introduced in this pull request?

For some reason, Katello JS snapshots are broken with theforeman/foreman#10598
Also removes references to @theforeman/vendor which isn't a thing anymore.

Considerations taken when implementing this change?

I'm still not sure if this is caused by the scalprum changes, or some coincidence with a PF update or something.

What are the testing steps for this pull request?

see that CI passes

Summary by Sourcery

Regenerate broken Katello JS snapshots to restore passing tests

Bug Fixes:

  • Update ContentDetails snapshot to reflect current component output
  • Update SubscriptionDetails snapshot to reflect current component output

Tests:

  • Refresh snapshot tests for ContentDetails and SubscriptionDetails

@sourcery-ai

sourcery-ai Bot commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Reviewer's Guide

This PR regenerates and updates two Jest snapshot files to fix test failures caused by recent component or dependency updates that altered the rendered output.

File-Level Changes

Change Details Files
Regenerated Jest snapshot for ContentDetails component
  • Ran snapshot update to capture current rendered output
  • Replaced outdated snapshot entries with updated structure
webpack/components/Content/Details/__tests__/__snapshots__/ContentDetails.test.js.snap
Regenerated Jest snapshot for SubscriptionDetails component
  • Ran snapshot update to reflect latest component rendering
  • Removed mismatched snapshot lines and added updated ones
webpack/scenes/Subscriptions/Details/__tests__/__snapshots__/SubscriptionDetails.test.js.snap

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jeremylenz - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jeremylenz

Copy link
Copy Markdown
Member Author
> npx eslint webpack/

Cannot read config file: /home/runner/work/katello/katello/katello/webpack/.eslintrc.js
Error: Could not find ./node_modules/@theforeman/vendor-core/ in /home/runner/work/katello/katello/foreman

why is it still trying to use theforeman/vendor-core?

@jeremylenz

Copy link
Copy Markdown
Member Author

why is it still trying to use theforeman/vendor-core?

looks like this is happening on other pull requests too

@sjha4

sjha4 commented Jul 15, 2025

Copy link
Copy Markdown
Member

Do we need something to get around this?

Comment thread .github/workflows/react_tests.yml Outdated
@jeremylenz
jeremylenz force-pushed the 38577-snapshots-scalprum branch from 8aadbec to c9222df Compare July 16, 2025 18:01
@jeremylenz
jeremylenz force-pushed the 38577-snapshots-scalprum branch from c9222df to e1f99c5 Compare July 16, 2025 18:02

@sjha4 sjha4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack..Tests look green.. 👍🏼

@jeremylenz
jeremylenz merged commit 40a4420 into Katello:master Jul 16, 2025
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants