Fixes #38577 - Fix snapshots - #11441
Merged
Merged
Conversation
Contributor
Reviewer's GuideThis PR regenerates and updates two Jest snapshot files to fix test failures caused by recent component or dependency updates that altered the rendered output. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @jeremylenz - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
Author
why is it still trying to use |
Member
Author
looks like this is happening on other pull requests too |
Member
|
Do we need something to get around this? |
jeremylenz
force-pushed
the
38577-snapshots-scalprum
branch
from
July 16, 2025 15:01
b38076e to
3e96f74
Compare
evgeni
reviewed
Jul 16, 2025
jeremylenz
force-pushed
the
38577-snapshots-scalprum
branch
from
July 16, 2025 18:01
8aadbec to
c9222df
Compare
jeremylenz
force-pushed
the
38577-snapshots-scalprum
branch
from
July 16, 2025 18:02
c9222df to
e1f99c5
Compare
jeremylenz
force-pushed
the
38577-snapshots-scalprum
branch
from
July 16, 2025 18:03
e1f99c5 to
6d8a01e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
For some reason, Katello JS snapshots are broken with theforeman/foreman#10598
Also removes references to @theforeman/vendor which isn't a thing anymore.
Considerations taken when implementing this change?
I'm still not sure if this is caused by the scalprum changes, or some coincidence with a PF update or something.
What are the testing steps for this pull request?
see that CI passes
Summary by Sourcery
Regenerate broken Katello JS snapshots to restore passing tests
Bug Fixes:
Tests: