Fixes #38436 - Override assign_taxonomy to check registered hosts before assigning to a new organization - #11396
Merged
Merged
Conversation
Contributor
Reviewer's GuideOverrides the assign_taxonomy bulk action to pre-check for hosts with active subscriptions in a different organization and block reassignment until they are unregistered, then delegates to the original implementation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @lfu - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
lfu
force-pushed
the
31030_change_org_loc
branch
from
June 24, 2025 14:28
c647354 to
ffc9bed
Compare
lfu
force-pushed
the
31030_change_org_loc
branch
from
June 27, 2025 20:04
ffc9bed to
a0dbe27
Compare
lfu
force-pushed
the
31030_change_org_loc
branch
from
July 11, 2025 20:28
f1add9c to
863ea57
Compare
…ore assigning to a new organization.
lfu
force-pushed
the
31030_change_org_loc
branch
from
July 22, 2025 17:54
863ea57 to
0f1699d
Compare
jeremylenz
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Based on theforeman/foreman#10538.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Summary by Sourcery
Prevent reassignment of registered hosts to a different organization by overriding the assign_taxonomy bulk action to validate hosts before proceeding.
Bug Fixes:
Enhancements: