ci: build, lint, and test on macOS#44
Closed
Karib0u wants to merge 1 commit into
Closed
Conversation
Add clippy-macos and test-macos jobs (mirroring the self-contained Windows jobs; no eBPF artifact needed) and wire them into the release gate, so the newly supported macOS target can't regress. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
Author
|
Closing — the macOS CI job can't pass against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds macOS to CI so the newly supported macOS target is built, linted, and tested on every push — closing the gap that let a macOS-only test regression slip through review on #42.
clippy-macosandtest-macosjobs onmacos-latest, mirroring the self-contained Windows jobs (no eBPF artifact needed).releasegate alongside the existing Linux/Windows jobs.Context
While reviewing #42 (first of the four-PR macOS series in #41), a
tests/reload.rsfailure was found that only reproduces on macOS — CI never would have caught it because there was no macOS runner. This adds that runner.Follow-up
After this merges, add
Clippy (macOS)andTests (macOS)to the branch-protection required status checks so they block, not just report.🤖 Generated with Claude Code