test(core): add vertical axis validation coverage to Dim.fill#2331
test(core): add vertical axis validation coverage to Dim.fill#2331suhaniiz wants to merge 2 commits into
Conversation
|
Hi @suhaniiz 👋 ⭐ Star this repo before your PR merges. Why? GSSoC 2026 contributors who star get priority review and points credit. After you star, push any commit (or re-run this check). The Thanks for your contribution to TermUI. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughExpanded ChangesDim layout test coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
This PR resolves a test coverage omission in the Dimension Algebra suite by expanding the
Dim.fill()specifications. It implements an explicit layout evaluation pass on the vertical axis (axis: 'vertical'), confirming that fills dynamically measure against contextualparentHeightproperties exactly as it maps againstparentWidthduring horizontal sweeps.Related Issue
Closes #2328
Which package(s)?
@termuijs/core
Type of Change
type:bug)type:feature)type:testing)Checklist
needs-starcheck blocks your merge otherwise.bun vitest runbun run buildtype: short description.GSSoC 2026 Participation
https://gssoc.girlscript.org/profile/suhaniizNotes for the Reviewer
Ensures full regression safety across both layout direction parameters. Checked locally against the
vitestexecution stack and passes successfully without any downstream dependency side effects.Summary by CodeRabbit