A11y screen reader support#2323
Conversation
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
This PR brings first-class Accessibility (a11y) Screen Reader support to TermUI! Terminal UIs have historically been black boxes to VoiceOver/NVDA. This update modifies
@termuijs/coreto inject semantic roles (e.g.role: 'button',ariaLabel: 'Submit Form') into the focus system.When a widget gains focus, the framework now intelligently announces it using invisible ANSI sequences (\x1b[8m) and terminal bells (\x07). Most importantly, the render engine now executes a final sweep at the end of every frame to move the physical (hidden) terminal cursor to the exact 2D
x,ycoordinates of the actively focused widget, allowing spatial screen readers to track the virtual layout accurately.Related Issue
Closes #2263
Which package(s)?
@termuijs/coreType of Change
type:bug)type:feature)type:docs)type:testing)type:refactor)type:design)type:accessibility)type:performance)type:devops)type:security)Checklist
needs-starcheck blocks your merge otherwise.bun vitest runbun run buildbun run typecheckCONTRIBUTING.md.type: short description.markDirty()(if your change affects rendering).anytypes without an inline comment explaining why.GSSoC 2026 Participation
https://gssoc.girlscript.org/profile/YOUR_PROFILE_ID_HEREScreenshots / Recordings (UI changes)
Notes for the Reviewer
The cursor repositioning happens inside
App.ts'srequestRender()macro-task just before handing off the differential diff to theRenderer. This is critical because if it happened earlier, the VDOM frame diffs would overwrite the cursor position and park it at the bottom of the screen.