Skip to content

Table pagination feature#2298

Open
desireddymohithreddy0925 wants to merge 4 commits into
Karanjot786:mainfrom
desireddymohithreddy0925:table-pagination-feature
Open

Table pagination feature#2298
desireddymohithreddy0925 wants to merge 4 commits into
Karanjot786:mainfrom
desireddymohithreddy0925:table-pagination-feature

Conversation

@desireddymohithreddy0925

Copy link
Copy Markdown

Description

This PR drastically improves navigation performance in the Table widget in @termuijs/widgets by introducing advanced keyboard pagination mechanics. It hooks into the pageup, pagedown, home, and end KeyEvent constants, allowing users to scroll through large datasets by full pages or jump to the extremities, preventing the need to hold the down arrow for thousands of rows.

Related Issue

Closes #2258

Which package(s)?

@termuijs/widgets

Type of Change

  • 🐛 Bug fix (type:bug)
  • ✨ Feature (type:feature)
  • 📝 Docs (type:docs)
  • 🧪 Tests (type:testing)
  • ♻️ Refactor (type:refactor)
  • 🎨 Design / UX (type:design)
  • ♿ Accessibility (type:accessibility)
  • ⚡ Performance (type:performance)
  • 🔧 DevOps / CI (type:devops)
  • 🔒 Security (type:security)

Checklist

  • ⭐ You starred the repo. The needs-star check blocks your merge otherwise.
  • Tests pass locally: bun vitest run
  • Build passes: bun run build
  • Typecheck passes: bun run typecheck
  • You read CONTRIBUTING.md.
  • Your PR title follows type: short description.
  • Widget state mutators call markDirty() (if your change affects rendering).
  • No new any types without an inline comment explaining why.
  • No unrelated refactors bundled into this PR.

GSSoC 2026 Participation

  • You are a GSSoC 2026 contributor.
  • Your GSSoC profile: https://gssoc.girlscript.org/profile/YOUR_PROFILE_ID_HERE

Screenshots / Recordings (UI changes)

Notes for the Reviewer

The pageup and pagedown logic dynamically calculates the pageSize using this._getContentRect().height on each keypress (subtracting the header rows if visible), ensuring that page jumps adapt seamlessly if the user resizes their terminal window.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@desireddymohithreddy0925, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f8212851-09dd-4381-a209-3e7ec102be15

📥 Commits

Reviewing files that changed from the base of the PR and between 65d1f7e and 2e70f65.

📒 Files selected for processing (1)
  • packages/widgets/src/data/Table.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the area:widgets @termuijs/widgets label Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:widgets @termuijs/widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] DataTable Widget with Sorting and Pagination

1 participant