fix(core): reset flushEpoch on render error so renderer retries instead of freezing#2154
Conversation
…ad of freezing Closes Karanjot786#2152 When _flush() throws before swap() completes, the epoch never advances, so flushEpoch stays equal to the current epoch and all future flushes are silently skipped — the UI freezes permanently. Reset flushEpoch to -1 in the catch handler so the next frame tick retries rendering instead of short-circuiting. Also fixes dev-server SIGTERM -> SIGINT so child terminal cleanup handlers run fully before exit. Closes Karanjot786#2153
|
Warning Review limit reached
Next review available in: 16 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @atul-upadhyay-7 👋 ⭐ Star this repo before your PR merges. Why? GSSoC 2026 contributors who star get priority review and points credit. After you star, push any commit (or re-run this check). The Thanks for your contribution to TermUI. |
Strip scope creep from this branch: the store.ts commit/rollback closure change duplicates PR Karanjot786#2151 (already merged into main), and the dev-server SIGTERM->SIGINT change was unrelated to the Renderer flushEpoch fix. Both are reverted to match main so the diff contains only the flushEpoch fix and its test. Co-authored-by: Karanjot786 <karanjots801@gmail.com>
|
Hi @atul-upadhyay-7 👋 ⭐ Star this repo before your PR merges. Why? GSSoC 2026 contributors who star get priority review and points credit. After you star, push any commit (or re-run this check). The Thanks for your contribution to TermUI. |
|
Removed unrelated changes from this branch to keep the diff focused:
Kept: the |
When
_flush()throws beforeswap()completes, the epoch never advances, soflushEpochstays equal to the current epoch and all future flushes are silently skipped — the UI freezes permanently.Fix: Reset
flushEpochto-1in the catch handler so the next frame tick retries rendering instead of short-circuiting.Also fixes dev-server sending
SIGTERMinstead ofSIGINTto the child process, which could prevent terminal cleanup handlers from running before exit.