Skip to content

Add margin-block-end to pds-textarea label wrapper #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michellechild wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add margin-block-end to pds-textarea label wrapper #778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libs/core/src/components/pds-textarea/pds-textarea.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
align-items: center;
display: flex;
justify-content: space-between;
margin-block-end: var(--pine-dimension-2xs);

@cursor cursor Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hidden label still adds spacing

Medium Severity

Adding margin-block-end on .pds-textarea__label-wrapper leaves a gap when hideLabel is true. Unlike pds-input, only the inner span is visually hidden, so the wrapper stays in flow and its new margin still reserves space above the field.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ee56267. Configure here.

@QuintonJason QuintonJason Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michellechild this is valid

Screenshot 2026-07-24 at 9 07 07 AM

@michellechild michellechild Jul 24, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuintonJason thank you yes agreed ! I saw this and just haven't had a chance to revisit which is why I didn't merge. Will try and get to it next week 👍

}

.pds-textarea__action {
Expand Down
Loading