chore: fix global CODEOWNERS pattern and route to current maintainers#776
Merged
Conversation
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
prsimp
reviewed
Jul 21, 2026
| # files. Maintained by the two remaining DSS maintainers after the team wound down. | ||
|
|
||
| - @Kajabi/dss-devs | ||
| * @QuintonJason @pixelflips |
Member
There was a problem hiding this comment.
Any reason not to use * @Kajabi/dss-devs to fix this? If it's that DSS isn't strictly a team anymore, we should use an interest group a la @Kajabi/gemfile-reviewers.
Contributor
Author
There was a problem hiding this comment.
Good call — kept it a team. @Kajabi/dss-devs is still active (admin on this repo, the two of us as members), so I pointed the global rule at the team rather than naming individuals. The real fix here was the - → * pattern; the owner just reverts to the team. If/when we stand up a fresh interest group, it is a one-line rename from here.
Per review: keep ownership on the (still-active) dss-devs team rather than naming individuals. The core fix — the '-' -> '*' global pattern — is unchanged.
prsimp
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two things, both maintenance for the incoming-contributor phase now that the DSS team has wound down:
Fixes a latent bug. The global-owners line was
- @Kajabi/dss-devs. In CODEOWNERS, patterns are gitignore-style —*matches all files, but a bare-matches only a file literally named-. GitHub doesn't flag it (it's syntactically valid), but it means no code-owner review has actually been required on general files — only/.github/(owned by PE) had a working rule. Changed to*.Routes to the real maintainers.
@Kajabi/dss-devsis a dissolved team (2 remaining members). Points ownership at the two people actually maintaining Pine now — @QuintonJason and @pixelflips — so the review gate survives the team being deleted.The
/.github/ @kajabi/production-engineeringrule is unchanged.Type of change
How Has This Been Tested?
GET /repos/Kajabi/pine/codeowners/errors(no syntax errors) and confirmed@QuintonJason/@pixelflipsare the twodss-devsmembers with write access.Checklist:
Note
Low Risk
Repository governance only; no application code or runtime behavior changes.
Overview
Fixes global code-owner coverage so GitHub actually requires review on normal paths. The global rule was
- @Kajabi/dss-devs; in CODEOWNERS that pattern only matches a file named-, not the whole tree, so only/.github/(production-engineering) had been enforcing owners.Replaces it with
* @Kajabi/dss-devsand adds a short comment documenting the mistake. The/.github/ @kajabi/production-engineeringline is unchanged.Reviewed by Cursor Bugbot for commit 8f495f6. Bugbot is set up for automated code reviews on this repo. Configure here.