Embed verified surgery atlas in local app builds - #4
Closed
KaiCao2003 wants to merge 2 commits into
Closed
Conversation
Owner
Author
|
Closing this draft because the public-repository cleanup removes licensed data and avoids repository-owned PDF embedding support. PR #5 supersedes the documentation and data-boundary work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
The historical page was translated twice even though PDFKit had already normalized its MediaBox origin, which cropped the artwork. The renderer also received no probe-plan geometry, so it could not create a real overlay. Four valid NP2013 paths could additionally overpaint into one visible line in a collapsed coronal projection. Finally, an opaque identity panel and per-page audit footer displaced the actual content.
User impact
The exported surgery packet now contains the complete atlas artwork, visible NP2003 or NP2013 vector shafts, and a readable coordinate row. Coronal and sagittal AP/ML direction conventions remain explicit. No temporary SVG sidecar or scattered atlas derivative is created.
Validation
The commercial atlas PDF, extracted pages, generated apps, release archives, and QA surgery-plan PDFs remain excluded from this public PR.