[REWRITE] Completely rewrite Menu Core to be more class focused#5
Draft
TechnikTil wants to merge 1 commit into
Draft
[REWRITE] Completely rewrite Menu Core to be more class focused#5TechnikTil wants to merge 1 commit into
class focused#5TechnikTil wants to merge 1 commit into
Conversation
Signed-off-by: TechnikTil <techniktil@tilnotdrip.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR completely rewrites Menu Core to be more close to the Funkin' codebase.
Note
This is still a draft due to me not being 100% done with this rewrite!
The main part of this rewrite:
Menu entries are classes now!
Instead of making a
Moduleto inject yourself into Menu Core, you can now make a new class extendingBaseMenu!An example can be found in
FunkinMenu.hxc.The original method still works, but is highly discouraged.