Reorganize sources into src/ and include/ subdirectories#2
Merged
Conversation
CMakeLists.txt expects src/*.cpp and include/*.h but files were at the repo root, causing the cmake configure step to fail with "Cannot find source file: src/main.cpp".
- Guard PACKCOM_WINDOWS define with #ifndef to stop redefinition warning (CMakeLists already sets it via add_compile_definitions) - Add #define NOMINMAX before <windows.h> so std::min/std::max are not shadowed by the Windows min/max macros (C2589 errors) - Change constexpr INVALID_SERIAL to static const — INVALID_HANDLE_VALUE involves a pointer cast and is not a valid constant expression (C2131)
Unpinned install pulled WiX v6 tool + WixToolset.UI.wixext v7.0.0-rc.2 which are incompatible with the v4 schema used in PackCom.wxs.
WiX v4 stores extension references relative to the current directory. Adding from repo root then building from installer/ meant the extension could not be found at build time.
XML comments cannot contain '--' (double dash). Replace decorative dash-line comments with '=' characters to satisfy the XML spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMakeLists.txt expects src/.cpp and include/.h but files were at the repo root, causing the cmake configure step to fail with "Cannot find source file: src/main.cpp".