Feat make create user helper private#64
Merged
Merged
Conversation
Jonathan-Zollinger
added a commit
that referenced
this pull request
May 13, 2026
Co-authored-by: Jonathan Zollinger <62955101+Jonathan-Zollinger@users.noreply.github.com>
Merged
Jonathan-Zollinger
added a commit
that referenced
this pull request
May 13, 2026
Co-authored-by: Jonathan Zollinger <62955101+Jonathan-Zollinger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch was created to resolve #62, by making createUser(client, user) into a private method and renaming it to createUserFromFaker(), and also modified it so a custom email can be inputted if you want to use an email not provided by faker to guarantee the user does not already exist. And finally I refactored the code so places that used to refer to the now private method instead go through the public createUser function.