create assignSponsorToProject#113
Open
HMS-Victory wants to merge 27 commits into
Open
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Jonathan-Zollinger
requested changes
Jun 23, 2026
| @Valid Project project = projectClient.getProject(projectId, " ", new GetProjectRequest()).block(); | ||
| if (user == null || project == null) { | ||
| throw new IllegalArgumentException("User API returned null for sponsorId = " + sponsorId + "projectId = "+projectId); | ||
| } |
Member
There was a problem hiding this comment.
If we leave this as is, this will result in a big stack trace in the console, which we don't want. use PrintErr and then log.err so that the ui is maintained, but we can still see all info in the logs.
Comment on lines
+355
to
+378
| "/api/v1/users/{userId}/limited": | ||
| get: | ||
| tags: | ||
| - User | ||
| parameters: | ||
| - name: userId | ||
| in: path | ||
| required: true | ||
| schema: | ||
| type: string | ||
| format: uuid | ||
| responses: | ||
| "200": | ||
| description: OK | ||
| content: | ||
| text/plain: | ||
| schema: | ||
| $ref: "#/components/schemas/UserResultLimited" | ||
| application/json: | ||
| schema: | ||
| $ref: "#/components/schemas/UserResultLimited" | ||
| text/json: | ||
| schema: | ||
| $ref: "#/components/schemas/UserResultLimited" |
Member
There was a problem hiding this comment.
We don't need this, let's use the userslimsearch which is already available
| printNormal("Successfully assigned sponsor %s to project %s", sponsorId, projectId); | ||
| log.atTrace().log("Successfully assigned sponsor to project"); | ||
| } catch (HttpClientResponseException e) { | ||
| printError("Failed to assign sponsor %s to project %s. (%s: %s)", |
Member
There was a problem hiding this comment.
make the print error clear what it is printing in the case the string interpolation fails or is formatted poorly,
printError("Failed to assign sponsor %s to project %s. %n%t Error Code %s: Error Message: %s",
the print error method will take multiline error prints and format it so the first line is a title and the following lines are formatted as a text body
This reverts commit ff38e55.
….java Co-authored-by: ZeterTheDuck <126122462+ZeterTheDuck@users.noreply.github.com> Signed-off-by: HMS-Victory <90852625+HMS-Victory@users.noreply.github.com>
Co-authored-by: ZeterTheDuck <126122462+ZeterTheDuck@users.noreply.github.com> Signed-off-by: HMS-Victory <90852625+HMS-Victory@users.noreply.github.com>
Signed-off-by: HMS-Victory <90852625+HMS-Victory@users.noreply.github.com>
change testuser property name from UUID to ID
Jonathan-Zollinger
force-pushed
the
Talbot/add-assign-sponsor-command
branch
from
July 11, 2026 02:26
0ed44a0 to
be502bd
Compare
Member
|
@HMS-Victory will you @ me when you're ready for my review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR accomplishes the following: