Support getCountries and getLocationByAddress endpoints#104
Merged
Jonathan-Zollinger merged 17 commits intoJun 3, 2026
Merged
Conversation
… method, rather than as a data input
Not all countries use states and counties, so these descriptions clarify their meaning
…locations/get-countries-and-get-location-by-address
Contributor
Author
|
A couple comments:
|
ZeterTheDuck
marked this pull request as ready for review
June 1, 2026 19:43
Jonathan-Zollinger
requested changes
Jun 2, 2026
Jonathan-Zollinger
left a comment
Jonathan-Zollinger
left a comment
Member
There was a problem hiding this comment.
please implement the one note I made, otherwise looks good and tests pass
Comment on lines
+1107
to
+1185
| mapId: | ||
| type: string | ||
| nullable: true | ||
| fullDisplayAddress: | ||
| description: "Full representation of this location's address" | ||
| type: string | ||
| nullable: true | ||
| address: | ||
| description: "Primary street address" | ||
| type: string | ||
| nullable: true | ||
| suite: | ||
| description: "Additional address details" | ||
| type: string | ||
| nullable: true | ||
| city: | ||
| type: string | ||
| nullable: true | ||
| civicCityId: | ||
| type: string | ||
| format: uuid | ||
| nullable: true | ||
| neighborhood: | ||
| type: string | ||
| nullable: true | ||
| county: | ||
| type: string | ||
| nullable: true | ||
| state: | ||
| type: string | ||
| nullable: true | ||
| postal: | ||
| type: string | ||
| nullable: true | ||
| country: | ||
| type: string | ||
| nullable: true | ||
| countryCode: | ||
| description: "ISO 3166-1 standard three-letter country code" | ||
| type: string | ||
| nullable: true | ||
| locationVisibilityId: | ||
| type: integer | ||
| format: int32 | ||
| missionId: | ||
| type: string | ||
| nullable: true | ||
| ccId: | ||
| type: string | ||
| nullable: true | ||
| stakeId: | ||
| type: string | ||
| nullable: true | ||
| areaId: | ||
| type: string | ||
| nullable: true | ||
| latitude: | ||
| type: number | ||
| format: double | ||
| longitude: | ||
| type: number | ||
| format: double | ||
| maxLatitude: | ||
| type: number | ||
| format: double | ||
| minLatitude: | ||
| type: number | ||
| format: double | ||
| maxLongitude: | ||
| type: number | ||
| format: double | ||
| minLongitude: | ||
| type: number | ||
| format: double | ||
| geoCodeOverride: | ||
| type: boolean | ||
| timezone: | ||
| type: string | ||
| nullable: true |
Member
There was a problem hiding this comment.
please re-collapse these
Member
|
looks good! tests pass! |
13 tasks
Contributor
Author
|
It appears that there was an improper merge in LocationSpec. For the test in lines 41-52, a similar test (getCountries) in this PR was detected as a refactor of an existing test (getBasicCountryIdentifiers) in main, and overwrote the existing test. I'll need to check the other PRs to make sure nothing similar happened to other schemas or branches. |
Contributor
Author
|
I will re-add that test in the |
Jonathan-Zollinger
pushed a commit
that referenced
this pull request
Jun 15, 2026
This test was accidentally removed in #104.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
/api/v1/locations/{language}/address/{address}and/api/v1/locations/{language}/countriesendpoints, which adds the CountryIdentifiers class, renaming the class with the same name to "CountryBasicIdentifiers".