refactor: wait for UIRR, formatting#11
Open
tristanwbireley wants to merge 1 commit into
Open
Conversation
Jonathan-Zollinger
requested changes
Jul 16, 2026
Jonathan-Zollinger
left a comment
Member
There was a problem hiding this comment.
looks good! Just a few changes
Comment on lines
+26
to
+29
| .EXAMPLE | ||
| 1. Get-TicketComments -TicketId 12345 | ||
| 2. Get-TicketComments -TicketId 12345 -CopyToClipboard | ||
| 3. Get-TicketComments -TicketId 12345 -OutputDirectory Downloads |
Member
There was a problem hiding this comment.
putting the examples together like this produces this output:
-------------------------- EXAMPLE 1 --------------------------
PS > 1. Get-TicketComments -TicketId 12345
2. Get-TicketComments -TicketId 12345 -CopyToClipboard
3. Get-TicketComments -TicketId 12345 -OutputDirectory Downloads
put these into separate examples like this:
.EXAMPLE
Get-TicketComments -TicketId 12345
.EXAMPLE
Get-TicketComments -TicketId 12345 -CopyToClipboard
.EXAMPLE
Get-TicketComments -TicketId 12345 -OutputDirectory Downloads
Comment on lines
+82
to
84
|
|
||
| # File overwrite check & confirmation message | ||
| if (Test-Path $filePath) { |
Member
There was a problem hiding this comment.
I personally don't like these AI generated overview comments. I think we're fine without them, considering this code is written in a fairly reasonable way.
|
|
||
| .EXAMPLE | ||
| 1. Set-TicketOrgAsArea -ViewID 123456 | ||
| 2. Set-TicketOrgAsArea -TicketArray $tickets |
Member
There was a problem hiding this comment.
See my comments for Set-TicketComments
Comment on lines
+19
to
+21
| .PARAMETER RequesterId | ||
| The unique identifier of the requester for whose tickets to search. | ||
| Defaults to 18885940524699 (the 'JustServe.org' email account). |
Member
There was a problem hiding this comment.
let's remove this param arg doc comment. it's a bad practice to hardcode the id in like this, so I don't want to take it a step further and add it in the docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For "Complete-InformationRequests", I added a call to execute "Update-InformationRequestRecipient" such that the primary function waits until this secondary function is finished executing before continuing.
I also made some minor formatting changes (primarily fixing the location of the Get-Help information and updating said information) to the following: