Skip to content

refactor: wait for UIRR, formatting#11

Open
tristanwbireley wants to merge 1 commit into
mainfrom
bireley/complete-information-requests-wait-for-UIRR
Open

refactor: wait for UIRR, formatting#11
tristanwbireley wants to merge 1 commit into
mainfrom
bireley/complete-information-requests-wait-for-UIRR

Conversation

@tristanwbireley

@tristanwbireley tristanwbireley commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

For "Complete-InformationRequests", I added a call to execute "Update-InformationRequestRecipient" such that the primary function waits until this secondary function is finished executing before continuing.

I also made some minor formatting changes (primarily fixing the location of the Get-Help information and updating said information) to the following:

  • Complete-InformationRequests
  • Update-InformationRequestRecipient
  • Set-TicketOrgAsArea
  • Get-TicketComments

@Jonathan-Zollinger Jonathan-Zollinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Just a few changes

Comment thread Get-TicketComments.ps1
Comment on lines +26 to +29
.EXAMPLE
1. Get-TicketComments -TicketId 12345
2. Get-TicketComments -TicketId 12345 -CopyToClipboard
3. Get-TicketComments -TicketId 12345 -OutputDirectory Downloads

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting the examples together like this produces this output:

    -------------------------- EXAMPLE 1 --------------------------

    PS > 1. Get-TicketComments -TicketId 12345
    2. Get-TicketComments -TicketId 12345 -CopyToClipboard
    3. Get-TicketComments -TicketId 12345 -OutputDirectory Downloads

put these into separate examples like this:

    .EXAMPLE
        Get-TicketComments -TicketId 12345
     .EXAMPLE
        Get-TicketComments -TicketId 12345 -CopyToClipboard
    .EXAMPLE
        Get-TicketComments -TicketId 12345 -OutputDirectory Downloads

Comment thread Get-TicketComments.ps1
Comment on lines +82 to 84

# File overwrite check & confirmation message
if (Test-Path $filePath) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't like these AI generated overview comments. I think we're fine without them, considering this code is written in a fairly reasonable way.

Comment thread Set-TicketOrgAsArea.ps1

.EXAMPLE
1. Set-TicketOrgAsArea -ViewID 123456
2. Set-TicketOrgAsArea -TicketArray $tickets

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments for Set-TicketComments

Comment on lines +19 to +21
.PARAMETER RequesterId
The unique identifier of the requester for whose tickets to search.
Defaults to 18885940524699 (the 'JustServe.org' email account).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove this param arg doc comment. it's a bad practice to hardcode the id in like this, so I don't want to take it a step further and add it in the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants