Spelling#100
Open
jsoref wants to merge 39 commits into
Open
Conversation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
jsoref
commented
Nov 28, 2021
jsoref
left a comment
jsoref
left a comment
Author
There was a problem hiding this comment.
Corrections were generally suggested by Google Sheets. But every choice is my fault.
Of the last couple of PRs I've made around GitHub this has by far the most things proportionally that I suspect will be rejected by a project.
If certain files/paths should be excluded, it's fairly trivial for me to drop items, just let me know.
Similarly, if a specific correction family is incorrect, I can trivially drop the commit, just let me know.
(I might be slow to respond until January, this was queued a while ago but I only got around to processing it tonight.)
| - name: creating firewall policy with draft mode state property defined should fail | ||
| request: | ||
| path: /firewall-policys | ||
| path: /firewall-policies |
Author
There was a problem hiding this comment.
I don't understand this, so I expect this isn't a correct change
| - name: create forwarding class | ||
| request: | ||
| path: /forwarding-classs | ||
| path: /forwarding-class |
| - name: create network policy with security group entries | ||
| request: | ||
| path: /network-policys | ||
| path: /network-policies |
| admin_project_with_network_policy1: &admin_project_with_network_policy1 | ||
| <<: *admin_project | ||
| network_policys: | ||
| network_policies: |
| request: | ||
| # TODO: parent_id is temporary fix as tests in gen_db_test.go are not cleaning database. | ||
| path: /network-policys?parent_id=47dd9220-9bf1-11e9-b422-538349e2da80 | ||
| path: /network-policies?parent_id=47dd9220-9bf1-11e9-b422-538349e2da80 |
| defaultTimeout = 30 * time.Second | ||
| ) | ||
|
|
||
| // Config represents parameters of Сollector in the config file |
| }{ | ||
| { | ||
| name: "Get multiple metadatas using UUID and FQName", | ||
| name: "Get multiple metadata using UUID and FQName", |
Author
There was a problem hiding this comment.
data is plural, although this sounds wrong both ways.
| obj := struct { | ||
| *alias | ||
| Policys interface{} `json:"policys"` | ||
| Policies interface{} `json:"policies"` |
Author
There was a problem hiding this comment.
It's possible that a thing like this is an api break and thus unacceptable.
| } | ||
|
|
||
| func (r *NetworkResponse) setPolicys(vn *models.VirtualNetwork) { | ||
| func (r *NetworkResponse) setPolicies(vn *models.VirtualNetwork) { |
Author
There was a problem hiding this comment.
It's possible that this is a public api and thus unacceptable
| // Here nil is returned - same as original config node | ||
| // However this silently discards mac address update request if not allowed | ||
| func (port *Port) getAsssociatedVirtualMachineID(vmi *models.VirtualMachineInterface) string { | ||
| func (port *Port) getAssociatedVirtualMachineID(vmi *models.VirtualMachineInterface) string { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@8e98257#commitcomment-60980950
The action reports that the changes in this PR would make it happy: jsoref@89d24b1
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.