fix(compress): bail loudly on empty / unchanged compression instead of silent data loss#292
Open
ousamabenyounes wants to merge 1 commit intoJuliusBrussee:mainfrom
Open
fix(compress): bail loudly on empty / unchanged compression instead of silent data loss#292ousamabenyounes wants to merge 1 commit intoJuliusBrussee:mainfrom
ousamabenyounes wants to merge 1 commit intoJuliusBrussee:mainfrom
Conversation
… unchanged target Closes JuliusBrussee#237 `/caveman:compress` could finish with "Validation passed" / "Compression completed successfully" while leaving the input file unchanged and the `*.original.md` backup empty (or vice versa). The orchestrator wrote the backup and the compressed output unconditionally and trusted Claude's response. Two failure modes slipped through: - Claude returned an empty (or whitespace-only) string — got written over both files without complaint. - Claude returned the input verbatim (refusal, echo, prompt-bleed) — passed validation trivially because there were no diffs to check. - The backup write succeeded on disk but with bytes dropped (Windows encoding mismatch, antivirus quarantine) — not detected before the input file was overwritten. Defensive checks added before any disk write touches the input: - Refuse empty-or-whitespace input up front. - Refuse empty-or-whitespace compressed output before opening any destination file. - Refuse compressed output that is identical to the input after strip. - After writing the backup, read it back and compare against the in-memory original; on mismatch, unlink the bad backup and abort before the input file is touched. Each refusal prints a concrete reason and a "no backup created" line so the user does not have to guess whether they lost data. Tests pin all four guards via `tests/test_compress_safety.py` with a mocked `call_claude`. Vibe coded by ousamabenyounes 🤖 Generated with [Ora Studio](https://studio.oratelecom.net)
|
Hi, The new tests import and exercise skills.compress.scripts.compress (a synced copy), so they won’t validate the canonical caveman-compress/scripts implementation; additionally, they don’t exercise the new backup readback mismatch guard (simulating dropped/corrupted bytes) described in the PR summary. Severity: remediation recommended | Category: reliability How to fix: Test canonical + corruption path Agent prompt to fix - you can give this to your LLM of choice:
We noticed a couple of other issues in this PR as well - happy to share if helpful. Found by Qodo. Free code review for open-source maintainers. |
JuliusBrussee
added a commit
that referenced
this pull request
Apr 30, 2026
…dation, frontmatter cleanup Five user-contributed fixes consolidated: * UTF-8 stdout (#289 by @ousamabenyounes) — reconfigure stdout/stderr at the top of cli.py so Windows cp1252 consoles don't crash on the ❌ glyph in error/validation branches and mask the real error. * Empty / unchanged compression guards (#292 by @ousamabenyounes, closes #237) — refuse empty input, refuse empty/whitespace/identical Claude output, read back the backup before touching the input. Five regression tests in tests/test_compress_safety.py. * Inline backtick validation (#309 by @hireblackout) — validate_inline_codes closes the silent-overwrite gap where `npm install` → `yarn install` passed validation. Wired into validate(); 11 unit tests in tests/test_validate_inline.py. * Frontmatter angle-bracket fix (#268 by @Bortlesboat, closes #266) — caveman-compress/SKILL.md description now uses FILEPATH instead of <filepath>, plus verify_repo gains a new verify_skill_frontmatter_upload_compatibility check, UTF-8 hardening for Windows, and the activation-banner regex no longer requires a trailing period. * Two test fixtures (claude-md-project.md, mixed-with-code.md) updated so the new inline-backtick validator passes — they were silently dropping `server/src/`, `type(scope): description`, and `status` references in compression. The fixture is documentation of "good" compression, so the fix is to preserve those references. Co-Authored-By: Ben Younes <ousama.benyounes@oratelecom.net> Co-Authored-By: hireblackout <hireblackout@users.noreply.github.com> Co-Authored-By: Andrew Barnes <Bortlesboat@users.noreply.github.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #237
Summary
/caveman:compresscould finish withValidation passed/Compression completed successfullywhile leaving the input file unchanged and the*.original.mdbackup empty (or vice versa). The orchestrator trusted Claude's response and wrote both files unconditionally, so three failure modes slipped through:Defensive checks added before any write touches the input:
strip().Each refusal prints a concrete reason and a "no backup created" line so the user does not have to guess whether they lost data.
Test plan
tests/test_compress_safety.py— five unit tests covering: empty input refused, empty compressed output rejected, whitespace-only compressed output rejected, identical compressed output rejected, real compression writes both files.python3 -m unittest tests.test_compress_safetypasses 5/5..original.mdis created on the rejection paths — the exact symptom from the bug report.Vibe coded by ousamabenyounes
🤖 Generated with Ora Studio
Generated by Ora Studio (with Claude Code)
Vibe coded by Ben Younes Ousama