Skip to content

fix forwarding of beta kwarg in quantile!(::AbstractArray...) #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nalimilan merged 2 commits into from
May 15, 2026
Merged

fix forwarding of beta kwarg in quantile!(::AbstractArray...) #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
714cd07
fix forwarding of `beta` kwarg in `quantile!(::AbstractArray...)`
MasonProtter May 14, 2026
67f838b
Add empty line
nalimilan May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Statistics.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,11 +1013,11 @@ function quantile!(v::AbstractVector, p::Union{AbstractArray, Tuple{Vararg{Real}
end
quantile!(a::AbstractArray, p::Union{AbstractArray,Tuple{Vararg{Real}}};
sorted::Bool=false, alpha::Real=1.0, beta::Real=alpha) =
quantile!(vec(a), p, sorted=sorted, alpha=alpha, beta=alpha)
quantile!(vec(a), p, sorted=sorted, alpha=alpha, beta=beta)

quantile!(q::AbstractArray, a::AbstractArray, p::Union{AbstractArray,Tuple{Vararg{Real}}};
sorted::Bool=false, alpha::Real=1.0, beta::Real=alpha) =
quantile!(q, vec(a), p, sorted=sorted, alpha=alpha, beta=alpha)
quantile!(q, vec(a), p, sorted=sorted, alpha=alpha, beta=beta)

quantile!(v::AbstractVector, p::Real; sorted::Bool=false, alpha::Real=1.0, beta::Real=alpha) =
_quantile(_quantilesort!(v, sorted, p, p), p, alpha=alpha, beta=beta)
Expand Down
5 changes: 5 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,6 +820,11 @@ end
@test [quantile(1:10, i/9) for i in 0:9] == 1:10
@test [quantile(1:14, i/13) for i in 0:13] == 1:14
end

# Statistics issue 204
Comment thread
nalimilan marked this conversation as resolved.
@testset "vector and abstract array methods should agree" begin
@test quantile!(reshape([1.,2,3,4,5],5,1), [.25,.5,.75]; alpha=0, beta=1) ≈ [1.25, 2.5, 3.75]
end
end

# StatsBase issue 164
Expand Down
Loading