Skip to content

Update Julia compat to 1.10 and update CI setup#213

Merged
devmotion merged 5 commits into
masterfrom
dw/ci_julia-1-10
Jan 2, 2025
Merged

Update Julia compat to 1.10 and update CI setup#213
devmotion merged 5 commits into
masterfrom
dw/ci_julia-1-10

Conversation

@devmotion

Copy link
Copy Markdown
Member

In #212, it was proposed to update the Julia compat to 1.10. I opened a separate PR for this move since there are quite many VERSION checks that we could (and should) get rid of in this update but these changes are really unrelated to #212 otherwise.

I used the opportunity to update the CI setup, and in particular add tests with min, lts and pre.

@timholy

timholy commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

I'll rebase on this PR once it's merged.

@codecov-commenter

codecov-commenter commented Dec 11, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.12%. Comparing base (b85c8ac) to head (024ece5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   91.61%   92.12%   +0.50%     
==========================================
  Files           9        9              
  Lines         680      660      -20     
==========================================
- Hits          623      608      -15     
+ Misses         57       52       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread .github/workflows/ci.yml Outdated
- 'pre'
os:
- ubuntu-latest
- ubuntu-latest # Apple Silicon

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to have this comment on this line or the following one?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, of course it should be moved to the following line.

Comment thread .github/workflows/ci.yml Outdated
@timholy

timholy commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

I wonder if it makes sense to bump the patch version here too, get a release out, and then bump again with #212?

@devmotion

Copy link
Copy Markdown
Member Author

I thought it would not be necessary to make a separate release with this PR since the PR does not (or at least should not) change the package itself in any way (apart from dropping support for Julia < 1.10).

@timholy

timholy commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

Agreed. There's a couple of minor changes that haven't been released, though: v0.11.31...master

Probably doesn't matter, though.

@timholy

timholy commented Dec 29, 2024

Copy link
Copy Markdown
Contributor

Bump. I think this is pretty safe, so no need to wait too long for @andreasnoack's review.

@devmotion devmotion merged commit fb363a3 into master Jan 2, 2025
@devmotion devmotion deleted the dw/ci_julia-1-10 branch January 2, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants