Fix findmin/max with dims for non-1 based inputs.#45822
Open
N5N3 wants to merge 3 commits into
Open
Conversation
N5N3
changed the title
dims for non-1 based inputs.
N5N3
changed the title
dims for non-1 based inputs.findmin/max with dims for non-1 based inputs.
N5N3
force-pushed
the
findminmax
branch
2 times, most recently
from
ef914a7 to
4c6c1c6
Compare
andrewjradcliffe
left a comment
andrewjradcliffe
left a comment
Contributor
There was a problem hiding this comment.
This is a good idea. Once approved, I'll need to update #45783 to utilize the same approach.
And add an optimized fallback for `keys::AbstractArray` (almost 2x faster with cheap `f`.)
1. remove `check_reducedims` within `mapfirst!`.
`init_array!` for other reductions also skip this check.
it should be safe to remove it as we add no `@inbounds`
2. remove unneeded `getindex`.
Co-Authored-By: Andrew Radcliffe <96091198+andrewjradcliffe@users.noreply.github.com>
11 tasks
vtjnash
added
merge me
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixs the possible error from
findmin/maxby ensuring that the input'skeyscontains no zero. (Close #38660)The added check might be expensive (
zi in keyscallsiteratebased fallback), but I can't find a non-breaking way to do the same check.This PR also add a faster fallback if the input's
keysis aAbstractArraywith the sameaxes.My local bench shows that it makes
findmin/maxalmost 2x faster iffis cheap.