Try updating tests to zarr-python 3#177
Closed
nhz2 wants to merge 1 commit into
Closed
Conversation
nhz2
changed the title
Pull Request Test Coverage Report for Build 13682974461Details
💛 - Coveralls |
nhz2
commented
Mar 5, 2025
|
|
||
| # Test reading in python | ||
| for julia_path in (pjulia, pjulia*".zip") | ||
| g = zarr.open_group(julia_path) |
Member
Author
There was a problem hiding this comment.
This change can be reverted once a bug in zarr-python is fixed. zarr-developers/zarr-python#2856
Member
There was a problem hiding this comment.
That looks more like a feature than a bug.
Closed
Member
|
@nhz2 I'm considering re-engaging on this. |
Member
|
I believe this was integrated into #232 . Please reopen if I am wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like strings and datetimes are not supported in zarr-python 3 yet: zarr-developers/zarr-python#2617 zarr-developers/zarr-python#2347 zarr-developers/zarr-python#2616
Maybe it makes sense to remove these types from the zarr-python compatibility tests.