Add AbstractTileArray#258
Merged
Merged
Conversation
AntonOresten
force-pushed
the
ao/abstract
branch
2 times, most recently
from
6cb59d0 to
9848040
Compare
Collaborator
Author
|
Merging this minimal interface per #66 (comment). Not worth documenting in the README for now. |
AntonOresten
force-pushed
the
ao/abstract
branch
from
9848040 to
1f58b9a
Compare
maleadt
added a commit
that referenced
this pull request
Jul 10, 2026
Align the kernel-wrapper machinery with Base.Broadcast's vocabulary and
trim the helper zoo introduced by the shape fixes:
- Replace BroadcastLeaf{P} with Extruded{K}, mirroring
Base.Broadcast.Extruded but with the keep-mask in the type domain
(it determines the static tile shape). Every array leaf is wrapped,
so the separate exact-shape load path disappears.
- Replace _to_tiled_bc with preprocess, the counterpart of
Base.Broadcast.preprocess.
- Drop _bc_result: scalars now convert through a new
convert(Tile{T}, ::Number) method, and the store site uniformly
expands with broadcast_to (a codegen no-op for full-shaped tiles).
- Drop _eval_bc_args in favor of a tuple map.
- Move host-memory rejection from a parent-walking blocklist into
TileArray construction itself: pointer(arr) returning a plain Ptr
means host memory. This also covers launch() arguments and
mapreduce, not just broadcast.
- Drop the macro return-value rewrite: materialize! already returns
the parent array since #258.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
maleadt
added a commit
that referenced
this pull request
Jul 10, 2026
Align the kernel-wrapper machinery with Base.Broadcast's vocabulary and
trim the helper zoo introduced by the shape fixes:
- Replace BroadcastLeaf{P} with Extruded{K}, mirroring
Base.Broadcast.Extruded but with the keep-mask in the type domain
(it determines the static tile shape). Every array leaf is wrapped,
so the separate exact-shape load path disappears.
- Replace _to_tiled_bc with preprocess, the counterpart of
Base.Broadcast.preprocess.
- Drop _bc_result: scalars now convert through a new
convert(Tile{T}, ::Number) method, and the store site uniformly
expands with broadcast_to (a codegen no-op for full-shaped tiles).
- Drop _eval_bc_args in favor of a tuple map.
- Move host-memory rejection from a parent-walking blocklist into
TileArray construction itself: pointer(arr) returning a plain Ptr
means host memory. This also covers launch() arguments and
mapreduce, not just broadcast.
- Drop the macro return-value rewrite: materialize! already returns
the parent array since #258.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal PR to allow for some cool downstream things that enable an entirely new separation of concerns when writing kernels.
See #66, #66 (comment)