Add test for an AGX miscompilation.#864
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Metal Benchmarks
Details
| Benchmark suite | Current: 97e128b | Previous: c558fb7 | Ratio |
|---|---|---|---|
array/accumulate/Float32/1d |
580708 ns |
579792 ns |
1.00 |
array/accumulate/Float32/dims=1 |
574250 ns |
568270.5 ns |
1.01 |
array/accumulate/Float32/dims=1L |
8844875 ns |
8840042 ns |
1.00 |
array/accumulate/Float32/dims=2 |
627709 ns |
620125 ns |
1.01 |
array/accumulate/Float32/dims=2L |
3339292 ns |
3343312 ns |
1.00 |
array/accumulate/Int64/1d |
883042 ns |
880125 ns |
1.00 |
array/accumulate/Int64/dims=1 |
1104000 ns |
1126542 ns |
0.98 |
array/accumulate/Int64/dims=1L |
9569208 ns |
9561833 ns |
1.00 |
array/accumulate/Int64/dims=2 |
1453625 ns |
1448208 ns |
1.00 |
array/accumulate/Int64/dims=2L |
6574625 ns |
6580854 ns |
1.00 |
array/broadcast |
365209 ns |
263396 ns |
1.39 |
array/construct |
3333 ns |
3333 ns |
1 |
array/permutedims/2d |
625834 ns |
624333 ns |
1.00 |
array/permutedims/3d |
1090792 ns |
1086250 ns |
1.00 |
array/permutedims/4d |
1701375 ns |
1707500 ns |
1.00 |
array/private/copy |
417604.5 ns |
417208 ns |
1.00 |
array/private/copyto!/cpu_to_gpu |
374604 ns |
379542 ns |
0.99 |
array/private/copyto!/gpu_to_cpu |
391083 ns |
376917 ns |
1.04 |
array/private/copyto!/gpu_to_gpu |
358979.5 ns |
352042 ns |
1.02 |
array/private/iteration/findall/bool |
1115292 ns |
1111500 ns |
1.00 |
array/private/iteration/findall/int |
1279625 ns |
1274520.5 ns |
1.00 |
array/private/iteration/findfirst/bool |
1406083 ns |
1388875 ns |
1.01 |
array/private/iteration/findfirst/int |
1438770.5 ns |
1415666 ns |
1.02 |
array/private/iteration/findmin/1d |
1572500 ns |
1561375 ns |
1.01 |
array/private/iteration/findmin/2d |
1259875 ns |
1254125 ns |
1.00 |
array/private/iteration/logical |
1822979.5 ns |
1819416 ns |
1.00 |
array/private/iteration/scalar |
2920500 ns |
2864417 ns |
1.02 |
array/random/rand/Float32 |
610375 ns |
605709 ns |
1.01 |
array/random/rand/Int64 |
627312.5 ns |
625541 ns |
1.00 |
array/random/rand!/Float32 |
526250 ns |
513333 ns |
1.03 |
array/random/rand!/Int64 |
496541.5 ns |
493583 ns |
1.01 |
array/random/randn/Float32 |
567625 ns |
565167 ns |
1.00 |
array/random/randn!/Float32 |
479250 ns |
474083 ns |
1.01 |
array/reductions/mapreduce/Float32/1d |
712959 ns |
694625 ns |
1.03 |
array/reductions/mapreduce/Float32/dims=1 |
482208 ns |
479125 ns |
1.01 |
array/reductions/mapreduce/Float32/dims=1L |
686916 ns |
684041 ns |
1.00 |
array/reductions/mapreduce/Float32/dims=2 |
495708 ns |
495187.5 ns |
1.00 |
array/reductions/mapreduce/Float32/dims=2L |
1333687.5 ns |
1331645.5 ns |
1.00 |
array/reductions/mapreduce/Int64/1d |
906333 ns |
880416 ns |
1.03 |
array/reductions/mapreduce/Int64/dims=1 |
781854.5 ns |
766375 ns |
1.02 |
array/reductions/mapreduce/Int64/dims=1L |
1084354.5 ns |
1082458 ns |
1.00 |
array/reductions/mapreduce/Int64/dims=2 |
937083 ns |
923500 ns |
1.01 |
array/reductions/mapreduce/Int64/dims=2L |
2169459 ns |
2167417 ns |
1.00 |
array/reductions/reduce/Float32/1d |
700334 ns |
685625 ns |
1.02 |
array/reductions/reduce/Float32/dims=1 |
482500 ns |
478417 ns |
1.01 |
array/reductions/reduce/Float32/dims=1L |
686750 ns |
684042 ns |
1.00 |
array/reductions/reduce/Float32/dims=2 |
396333 ns |
389959 ns |
1.02 |
array/reductions/reduce/Float32/dims=2L |
486687.5 ns |
480208 ns |
1.01 |
array/reductions/reduce/Int64/1d |
898229.5 ns |
873541 ns |
1.03 |
array/reductions/reduce/Int64/dims=1 |
792125 ns |
765958 ns |
1.03 |
array/reductions/reduce/Int64/dims=1L |
1079417 ns |
1077958 ns |
1.00 |
array/reductions/reduce/Int64/dims=2 |
933209 ns |
920917 ns |
1.01 |
array/reductions/reduce/Int64/dims=2L |
2150708 ns |
2149125 ns |
1.00 |
array/shared/copy |
154000 ns |
154667 ns |
1.00 |
array/shared/copyto!/cpu_to_gpu |
40083 ns |
39958 ns |
1.00 |
array/shared/copyto!/gpu_to_cpu |
40125 ns |
39667 ns |
1.01 |
array/shared/copyto!/gpu_to_gpu |
40417 ns |
40125 ns |
1.01 |
array/shared/iteration/findall/bool |
1121167 ns |
1119750 ns |
1.00 |
array/shared/iteration/findall/int |
1283541 ns |
1284000 ns |
1.00 |
array/shared/iteration/findfirst/bool |
1119875 ns |
1111667 ns |
1.01 |
array/shared/iteration/findfirst/int |
1149542 ns |
1164771 ns |
0.99 |
array/shared/iteration/findmin/1d |
1302958 ns |
1293145.5 ns |
1.01 |
array/shared/iteration/findmin/2d |
1274312.5 ns |
1261709 ns |
1.01 |
array/shared/iteration/logical |
1644917 ns |
1756208 ns |
0.94 |
array/shared/iteration/scalar |
3474 ns |
3463.5 ns |
1.00 |
integration/byval/reference |
1137375 ns |
1136167 ns |
1.00 |
integration/byval/slices=1 |
1138645.5 ns |
1142958 ns |
1.00 |
integration/byval/slices=2 |
2048645.5 ns |
2048062.5 ns |
1.00 |
integration/byval/slices=3 |
7066146 ns |
7145750 ns |
0.99 |
integration/metaldevrt |
455375 ns |
437709 ns |
1.04 |
kernel/indexing |
356542 ns |
392042 ns |
0.91 |
kernel/indexing_checked |
531125 ns |
525125 ns |
1.01 |
kernel/launch |
1975 ns |
1958.4 ns |
1.01 |
kernel/rand |
523291 ns |
515250 ns |
1.02 |
latency/import |
1780823417 ns |
1784385375 ns |
1.00 |
latency/precompile |
39578670021.5 ns |
39556254479 ns |
1.00 |
latency/ttfp |
2115412584 ns |
2115514917 ns |
1.00 |
metal/synchronization/context |
533.0310880829015 ns |
519.9742268041238 ns |
1.03 |
metal/synchronization/stream |
279.4117647058824 ns |
272.396875 ns |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #864 +/- ##
==========================================
+ Coverage 86.57% 86.61% +0.04%
==========================================
Files 76 76
Lines 5131 5133 +2
==========================================
+ Hits 4442 4446 +4
+ Misses 689 687 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x-ref JuliaGPU/GPUCompiler.jl#862