Conversation
Replace the external pygmentize dependency with Highlights.jl and tree-sitter grammar JLLs, giving out-of-the-box highlighting of LLVM IR, PTX, SPIR-V and GCN assembly (the latter two previously unsupported or requiring a recent Pygments). SPIR-V output from spirv-dis is now also routed through the highlighter. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
==========================================
- Coverage 81.40% 0.00% -81.41%
==========================================
Files 25 25
Lines 4755 4608 -147
==========================================
- Hits 3871 0 -3871
- Misses 884 4608 +3724 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the external
pygmentizedependency with Highlights.jl 0.6 (tree-sitter based) and dedicated grammar JLLs, so syntax highlighting works out of the box without a Python installation:tree_sitter_ptx_jll/tree_sitter_spirv_jll/tree_sitter_gcn_jll: newly-written tree-sitter grammars for PTX, SPIR-V assembly, and GCN/AMDGPU assembly;tree_sitter_llvm_jll: packaged from the existingbenwilliamgraham/tree-sitter-llvm, replacingInteractiveUtils.print_llvm.Highlighting is keyed on the target's
source_code, with unknown formats passing through unhighlighted.spirv-disoutput is now also routed through the highlighter (SPIR-V and GCN previously required Pygments >= 2.16 / 2.8, and SPIR-V wasn't supported at all). Failures during highlighting warn once and fall back to plain output. The theme is configurable throughGPUCompiler.highlight_theme[].Note
The four JLLs were registered in General today; CI will fail to resolve until the package servers pick up the new registrations.
Tested locally: full test suite passes on 1.12 (493 pass, 2 pre-existing broken), including new tests covering ANSI output for all four languages plus passthrough behavior.
🤖 Generated with Claude Code