Keep unrelocated constgv globals as declarations.#872
Merged
Conversation
Julia object references (julia.constgv globals) are kept session-portable by stripping their initializers after codegen, with relocate_gvs! baking in the absolute addresses at the toplevel link step. Leaving them behind as internal globals with a null initializer made them fair game for optimization passes that run before relocation -- notably the GlobalOpt run in the PTX back-end's finish_module! -- which folded loads of them to inline nulls and deleted the globals, constant-folding e.g. device-side comparisons against Symbol literals (JuliaGPU/CUDA.jl#3185). Demote them to external declarations instead, which no pass can fold, and have relocate_gvs! restore initializer and linkage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
- Coverage 81.40% 81.39% -0.02%
==========================================
Files 25 25
Lines 4755 4761 +6
==========================================
+ Hits 3871 3875 +4
- Misses 884 886 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia object references (julia.constgv globals) are kept session-portable by stripping their initializers after codegen, with relocate_gvs! baking in the absolute addresses at the toplevel link step. Leaving them behind as internal globals with a null initializer made them fair game for optimization passes that run before relocation -- notably the GlobalOpt run in the PTX back-end's finish_module! -- which folded loads of them to inline nulls and deleted the globals, constant-folding e.g. device-side comparisons against Symbol literals (JuliaGPU/CUDA.jl#3185). Demote them to external declarations instead, which no pass can fold, and have relocate_gvs! restore initializer and linkage.