Use upcoming TypeEgal dispatch keys for type callees#871
Merged
Conversation
The Base PR JuliaLang/julia#62001 is expected to spell exact closed type-object dispatch keys as Core.TypeEgal. When looking up method instances from a stable function type, use that upcoming dispatch spelling for closed Type{T} callee keys so constructor calls such as Memory{Int}(undef, n) remain compatible with Base.isdispatchtuple. AI disclosure: This commit was prepared with assistance from generative AI. The resulting PR should be checked carefully by a maintainer before merging. Co-authored-by: OpenAI Codex <codex@openai.com>
After JuliaLang/julia#62001, type-valued arguments (not just callees) specialize on Core.TypeEgal keys, and Type{T} elements anywhere in the signature fail Base.isdispatchtuple. Normalize all signature elements instead of only the function type. Also make the test compatible with Julia 1.10 by constructing a Vector instead of a Memory, and cover the argument position. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 10, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
==========================================
- Coverage 81.40% 81.39% -0.02%
==========================================
Files 25 25
Lines 4755 4763 +8
==========================================
+ Hits 3871 3877 +6
- Misses 884 886 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase and fix of #865