Conversation
Fixes nightly CI: LLVM_jll v20.1.8's platform augmentation uses a dynamic `cglobal` that Julia 1.14 rejects (JuliaLang/julia#61709); v21.1.8+1 ships the fixed augmentation (JuliaPackaging/Yggdrasil#13664) and is only resolvable on 1.14+. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
GPUCompiler's tests don't use LLVM_jll directly. FileCheck.jl (which provides the @FileCheck macros) already depends on LLVM_jll and locates the FileCheck binary via its artifact, so the explicit test dep only acted as a version bound -- and that bound was what capped LLVM_jll at the broken v20.1.8+0 build on nightly. Dropping the dep lets FileCheck.jl govern: on 1.14 it pulls the fixed LLVM_jll v21.1.8+1, and older Julia is unaffected (julia-compat keeps them on <= v20, which they accept). This supersedes the compat bump in the previous commit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
==========================================
+ Coverage 79.60% 80.02% +0.41%
==========================================
Files 25 25
Lines 4805 4805
==========================================
+ Hits 3825 3845 +20
+ Misses 980 960 -20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All
Julia nightlyCI jobs have failed since 2026-06-29. Julia 1.14 nightly (JuliaLang/julia#61709) rejectscglobalcalls whose library-name element is a computed expression, enforced at method-definition time — so merelyinclude-ing such a file throws:test/Project.tomlpinnedLLVM_jll = "15,16,18,20". On nightly that capped LLVM_jll at v20.1.8+0, whoseplatform_augmentation.jlcontains exactly such a call:Pkg.test→instantiate→download_artifactsruns each augmented JLL'sselect_artifacts.jlin a subprocess; including that file now throws and kills the wholePkg.test.Fix
GPUCompiler's tests never use LLVM_jll directly — they use FileCheck.jl's
@filecheck/@check_*macros. FileCheck.jl itself depends on LLVM_jll and locates the FileCheck binary via its artifact (joinpath(LLVM_jll.artifact_dir, "tools", "FileCheck")). So the explicitLLVM_jllentry in the test deps was vestigial; its only effect was the version bound, and that bound is what pinned the broken v20.1.8+0 build on nightly.Dropping the dep lets FileCheck.jl govern resolution:
Libdl.dlsym(dlopen(...))(JuliaPackaging/Yggdrasil#13664).cglobal.Verification
Full suite on nightly (1.14.0-DEV), with
LLVM_jllremoved from the test deps: resolves FileCheck v1.2.0 + LLVM_jll v21.1.8+1, FileCheck binary found, 336 pass, 3 broken. Nocglobalinstantiate error.🤖 Generated with Claude Code