Add llvm_gnu_pubnames to Interface and set llvm_debug_info for native target#456
Open
vchuravy wants to merge 1 commit into
Open
Add llvm_gnu_pubnames to Interface and set llvm_debug_info for native target#456vchuravy wants to merge 1 commit into
vchuravy wants to merge 1 commit into
Conversation
vchuravy
commented
May 22, 2023
| runtime_slug(job::CompilerJob{NativeCompilerTarget}) = "native_$(job.config.target.cpu)-$(hash(job.config.target.features))$(job.config.target.jlruntime ? "-jlrt" : "")" | ||
| uses_julia_runtime(job::CompilerJob{NativeCompilerTarget}) = job.config.target.jlruntime | ||
|
|
||
| function llvm_debug_info(@nospecialize(job::CompilerJob{NativeCompilerTarget})) |
Member
Author
There was a problem hiding this comment.
@gbaraldi I was debating to use simply FULL or Base.default_debug_info_kind() for all Native targets,
but maybe best not to change this for StaticCompiler.jl?
Member
There was a problem hiding this comment.
StaticCompiler actually defines it's own target so I don't see an issue.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
==========================================
+ Coverage 80.43% 80.46% +0.02%
==========================================
Files 25 25
Lines 4866 4873 +7
==========================================
+ Hits 3914 3921 +7
Misses 952 952 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
maleadt
force-pushed
the
master
branch
5 times, most recently
from
1d233d7 to
e18b7c2
Compare
vchuravy
force-pushed
the
vc/debug_info_native
branch
from
c39b534 to
5439ad0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.