feat: support GNSSDecoder 2#43
Merged
Merged
Conversation
GNSSDecoder 2 is a ground-up redesign. The pieces PVT touches changed as follows: - GPS types renamed: GPSL1Data -> GPSL1CAData, GPSL1Constants -> GPSL1CAConstants, GPSL1Cache -> GPSL1CACache. - GNSSDecoderState dropped the raw_buffer, buffer and num_bits_buffered fields (the soft-symbol decoder no longer holds packed bits). Source only references GNSSDecoderState as a type parameter and never reads the removed buffer fields, so the sole src change is the GPS data struct rename in the type annotations. Tests are updated for the renames and for the dropped positional constructor arguments. BitIntegers is removed since it only existed to spell the captured bit-buffer literals. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 7 7
Lines 360 360
=======================================
Hits 334 334
Misses 26 26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
GNSSDecoder 2 depends on Aff3ct, whose aff3ct_jll has no Windows binaries, so GNSSDecoder 2 (and thus PVT) cannot run on Windows. Drop windows-latest from the CI matrix, leaving a commented-out entry to restore once Aff3ct gains Windows support. The benchmark fixtures construct GNSSDecoderState positionally, and AirspeedVelocity runs them against both the PR (GNSSDecoder 2) and base (GNSSDecoder 1.3) revisions. Route construction through a version-adaptive helper that branches on whether the dropped raw_buffer/buffer fields are present, shim the renamed GPS L1 C/A types, and drop the now-unused BitIntegers buffer literals. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
GNSSDecodercompat to2. v2 is a ground-up redesign; the pieces PVT touches changed as follows:GPSL1DataGPSL1CADataGPSL1ConstantsGPSL1CAConstantsGPSL1CacheGPSL1CACacheGNSSDecoderStatefieldsraw_buffer,buffer,num_bits_bufferedThe headline v2 break (
decodenow takes soft symbols instead of packed bits) does not affect PVT, which never callsdecode.Changes
GNSSDecoder = "1.3"→"2".sat_time.jl,ionosphere.jl,PositionVelocityTime.jl):GPSL1Data→GPSL1CADatain type annotations. This is the only src change needed — PVT usesGNSSDecoderStatepurely as a type parameter and never reads the removed buffer fields.raw_buffer,buffer,num_bits_buffered) from the positionalGNSSDecoderState(...)calls. Verified the*Constantspositional field order and theGalileoE1B*/GPSL1CADatafield sets are unchanged between versions.UInt288/UInt320defs) — it only existed to spell the captured bit-buffer literals, which no longer exist.Versioning is left to the semantic-release CI; the
feat:commit yields a minor bump.Test plan
🤖 Generated with Claude Code