feat: export is_decoding_completed_for_positioning for PVT readiness#74
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 14 14
Lines 1519 1520 +1
=======================================
+ Hits 1491 1492 +1
Misses 28 28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Export the positioning-readiness predicate and add a `GNSSDecoderState` method that forwards to the validated `data` field, so a receiver (e.g. PositionVelocityTime.jl) can gate PVT on it alongside `is_sat_healthy` without reaching into decoder internals. Whenever the predicate is `true` the health field `is_sat_healthy` inspects is guaranteed decoded, so the two checks compose safely. The docstring records what it deliberately does not gate on (ephemeris freshness, second-order corrections, the alert flag). Also document the export in the API reference, which the docs build requires via `checkdocs = :exports`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
giove-a
force-pushed
the
sc/export-decoding-complete-for-pvt
branch
from
July 7, 2026 11:40
de6e5f5 to
07b01b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exports
is_decoding_completed_for_positioningso downstream consumers (e.g.PositionVelocityTime.jl) can gate use of a satellite in a fix without reachinginto decoder internals. It pairs with the already-exported
is_sat_healthy:Changes
is_decoding_completed_for_positioning.GNSSDecoderStatemethod that forwards to the validateddatafield(not
raw_data), mirroringis_sat_healthy(state). It only returnstrueonce the required message set has passed CRC/parity and the cross-subframe
issue-of-data consistency check that promotes
raw_data→data.checkdocs = :exports).false;fully decoded state →
true).Guarantees
SV clock polynomial (plus week number / single-band group delay where those
signals fold them into the required set).
the predicate is
true, the exact health fieldis_sat_healthyreads hasalready been decoded — so the two checks compose safely without a separate
nothingguard.Deliberate non-guarantees (documented in the docstring)
A
trueis a necessary condition, not a blanket "no further thinking":notion of "now", so consumers must still reject ephemerides outside their fit
interval.
T_GD/ISC_*beyond the required band,Klobuchar ionosphere, and UTC params are intentionally excluded (broadcast
far less often); apply when present, treat
nothingas zero.is_sat_healthyreflects broadcast health bits only. GPSL1 C/A and CNAV (L5I/L2C) also carry a per-message alert flag
(
state.data.alert_flag) that a strict-integrity receiver may want to honourseparately. (Galileo's equivalent — Data Validity Status — is already folded
into
is_sat_healthy; L1C-D has no alert flag.)Testing
state method.
checkdocs, doctests, cross-references).JuliaFormatter2.8.5 leavessrc/testunchanged.🤖 Generated with Claude Code