Simplify Hamiltonian operator names - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NonRelativisticKinetictoKineticandCoulombPotentialtoCoulombCustomandTabulatedfor user-defined potentialsWhy
The previous API mixed verbose implementation-oriented names with mathematical names. The new naming scheme uses concise mathematical names for built-in operators and concise representation names for user-supplied potentials.
Impact
This is a breaking public API rename. The previous operator type names are removed rather than retained as aliases.
Validation
julia --project=. -e "using Pkg; Pkg.test()"git diff --checkThis pull request was developed with assistance from Codex using GPT-5.6 Sol with High reasoning effort.