avoid depending on heavily invalidating pacakges#3538
Open
KristofferC wants to merge 1 commit into
Open
Conversation
These are not used in the package and should hence not be depended on
Member
|
I am OK to proceed as @KristofferC proposes, but before moving forward a comment from other involved contributors is welcome. |
Member
|
Would there be a way to store precompiled code for the extension so that no recompilation is needed after loading InlineStrings and SentinelArrays? For example, if we called |
Member
|
I echo @bkamins's question from the original issue/PR: should we instead focus on fixing the invalidations in these upstream packages? I'm happy to help push on that; I just wasn't aware of the issue or what is being measured exactly in calling them heavily invalidating packages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are not used in the package and should hence not be depended on. Adding heavily invalidating packages as dependencies kind of just "kicks the can down the road" and causes DataFrames to be unattractive to depend on.
Tagging some people who were active in #3285: @bkamins, @timholy, @quinnj, @nalimilan