Skip to content

fix: avoid complex powers in equation sorting #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AayushSabharwal merged 1 commit into from
Jul 6, 2026
Merged

fix: avoid complex powers in equation sorting #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ModelingToolkitTearing/src/tearingstate.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ function __get_expression_sort_key!(
end
v = convert(Float64, v)
for t in arg_k
push!(result, (t[1], t[2] ^ v * cf, t[3] + v))
push!(result, (t[1], abs(t[2]) ^ v * cf, t[3] + v))
end
length(result) > 100 && break
end
Expand All @@ -546,7 +546,7 @@ function __get_expression_sort_key!(
@match args[2] begin
BSImpl.Const(; val) => if val isa Real
v = convert(Float64, val)
return map(k -> (k[1], k[2] ^ v, k[3] + v), base_key)
return map(k -> (k[1], abs(k[2]) ^ v, k[3] + v), base_key)
else
length(base_key) > 100 && return base_key
return vcat(base_key, get_expression_sort_key!(cache, args[2], var2idx, canonical_ranks))
Expand Down
8 changes: 8 additions & 0 deletions lib/ModelingToolkitTearing/test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,3 +340,11 @@ MTKTearing.is_timevarying_operator(::Op3) = true
ci = MTKTearing.ClockInference(ts)
@test_throws MTKTearing.ExpectedDiscreteClockPartitionError MTKTearing.infer_clocks!(ci)
end

@testset "Equation sorting does safe exponentiation" begin
# https://github.com/SciML/ModelingToolkit.jl/issues/4708
@variables x(t) y(t)
@named sys = System([D(x) ~ -x, y ~ (1 - 2x)^0.5], t)
# This used to run `(-2) ^ 0.5` which hit a `DomainError`
@test_nowarn mtkcompile(sys)
end
Loading