Skip to content

Hole06#4

Open
D4rkP4ng0l1n wants to merge 11 commits into
mainfrom
hole06
Open

Hole06#4
D4rkP4ng0l1n wants to merge 11 commits into
mainfrom
hole06

Conversation

@D4rkP4ng0l1n

Copy link
Copy Markdown
Collaborator

No description provided.

@D4rkP4ng0l1n

Copy link
Copy Markdown
Collaborator Author

On remplace tout ce qui contient le mot "symbol" par le mot "player"

Comment thread src/12_RefactoringGolf/hole1/kata.ts Outdated
const thirdColumn = 2;

const playerO = 'O';
const emptyPlay = ' ';

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remplacer emptyPlay par noPlayer

Comment thread src/12_RefactoringGolf/hole1/kata.ts Outdated
private _lastSymbol = emptyPlay;
private _board: Board = new Board();

public Play(symbol: string, x: number, y: number): void {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remplacer symbol par player

Comment thread src/12_RefactoringGolf/hole1/kata.ts Outdated
export class Game {
private _lastSymbol = ' ';
private _toto: Board = new Board();
private _lastSymbol = emptyPlay;

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remplacer _lastSymbol par _lastPlayer

Comment thread src/12_RefactoringGolf/hole1/kata.ts Outdated
return this._plays.find((t: Tile) => t.hasSameCoordinatesAs(new Tile(x, y, emptyPlay)))!;
}

public AddTileAt(symbol: string, x: number, y: number): void {

@D4rkP4ng0l1n D4rkP4ng0l1n Nov 30, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changer le symbol de AddTileAt par player

Comment thread src/12_RefactoringGolf/hole1/kata.ts Outdated
}

this._plays.find((t: Tile) => t.X == x && t.Y == y)!.Symbol = symbol;
private isRowFullWithSameSymbol(row: number) {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isRowFullWithSameSymbol devient isRowFullWithSamePlayer

Comment thread src/12_RefactoringGolf/hole1/kata.ts Outdated
}

return ' ';
get Symbol() {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remplacer Symbol par Player

…yer"

+ Remplacement de emptyPlay par noPlayer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants