CT-3249 Fix for the Token Payments screen rotation state being lost#349
Merged
stefan-tudor merged 2 commits intoJun 8, 2026
Merged
Conversation
RafalOzogJudopay
commented
Jun 6, 2026
|
|
||
| class TokenPaymentsActivity : ComponentActivity() { | ||
| private val viewModel = TokenPaymentsViewModel() | ||
| private lateinit var viewModel: TokenPaymentsViewModel |
Contributor
Author
There was a problem hiding this comment.
Viewmodel init adjusted to persist the state (will be initialised from the factory).
RafalOzogJudopay
commented
Jun 6, 2026
|
|
||
| val judo = intent.parcelable<Judo>(JUDO_OPTIONS) | ||
| check(judo != null) { "Judo object is required" } | ||
| val judo = requireNotNull(intent.parcelable<Judo>(JUDO_OPTIONS)) { "Judo object is required" } |
Contributor
Author
There was a problem hiding this comment.
This check I have adjusted to have the same form as in DemoNoUIPaymentsActivity, for consistency.
|
stefan-tudor
approved these changes
Jun 8, 2026
stefan-tudor
deleted the
CT-3249-token-payments-activity-losing-state-on-rotation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: The state was lost on rotation as in this screen viewmodel was not persisted.
Fix: The viewmodel in Token Payments is now persisted in the same way as in DemoNoUIPaymentActivity.
Testing video:
demo.webm