[codex] Prepare replay engine for release rule APIs#1
Merged
Conversation
Spray chart: parse hit location (x, y) from ball_in_play defender entries and store per-player and per-team. Includes hrLocation fallback for over-the-fence home runs. Lineup events: handle squash_lineup_index (player removal + compaction), reorder_lineup (insert-style batting order changes), and sub_players (substitutions including baserunner identity swap). Run scoring fixes: - Unify player run credit with linescore scoring in handle_base_running so auto-scored confirmations don't double-count - Push displaced runners back when remained_on_last_play restores an auto-scored runner to a base that was filled by auto-advance Adds 10U Mariners/Brewers Apr 12 test data (15-14, matches GC). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares
diamond-replayfor broader release by tightening the public API, adding quality gates, and refactoring simulated rule replay behind an internal rule compiler pipeline.What changed
ReplayOptionsandRuleSetas the supported simulation API.rules/with shared stream traversal and shared shadow state.Validation
Local gates passed:
cargo fmt --checkcargo clippy --all-targets -- -D warningscargo test --all-targetscargo test --docRUSTDOCFLAGS='"'-D warnings'"' cargo doc --no-depscargo packageThe local commit hooks also ran
cargo testsuccessfully on each committed slice.