[MU3] Add the possibility to use custom ScoreFonts by Jojo-Schmitz · Pull Request #82 · Jojo-Schmitz/MuseScore

Jojo-Schmitz · 2023-03-05T10:37:58Z

Shamelessly stolen (from https://github.com/cbjeukendrup/MuseScore/tree/custom-music-fonts, actually rather from. https://github.com/cbjeukendrup/MuseScore/tree/mu3-custom-scorefonts) ;-)

Jojo-Schmitz · 2023-03-05T12:10:10Z

@cbjeukendrup: any idea why almost all mtests crash?

cbjeukendrup · 2023-03-05T19:19:54Z

I'm afraid I won't have time to look into this very soon, but I'll add it to my list :)

diedeno · 2023-03-07T10:18:17Z

Howto use custom Scorefonts.

-create new directory 'ScoreFonts', on the same level as Scores, Plugins, SoundFonts ..
-check Edit/.Preferences/Folders if path to ScoreFonts is correct (a space in name gives problems in Linux)
-get a Smufl compatible font (e.g. Leipzig, Sebastian, legato, ...)
-make a directory for each font with it's name, e.g.:
├── legato
│   ├── Legato.otf
│   └── metadata.json
You need the font (otf or ttf) and a json file. Rename the json file to "metadata.json"
Restart MuseScore.
You should be able to select the newly installed font via Format/Style/Score/Musical Symbols Font.
If there is no txt font available, you can always choose the text font from another package
If there are spaces in the font name (e.g; Golden Age), remove them as this does not work under Linux.
e.g.
├── goldenage
│   ├── GoldenAge.otf
│   └── metadata.json

Standard Music Font Layout (SMuFL) compatible Fonts.

SIL Font Licence

Sebastian by Florian Kretlow
https://github.com/fkretlow/sebastian/releases

Leipzig (verovio)
https://github.com/rism-digital/verovio/tree/develop/fonts

Finale Smufl Fonts:
Finale Maestro
Finale Broadway
Finale Ash
Finale Engraver
Finale Jazz
Finale Legacy
Finale Maestro Text
Finale Broadway Legacy Text
Finale Broadway Text
Finale Ash Text
Finale Lyrics
Finale Jazz Text
https://makemusic.zendesk.com/hc/en-us/articles/1500013053461-MakeMusic-Fonts-and-Licensing-Information

GoldenAge
https://github.com/benwiggy/GoldenAge

eNote legato
https://github.com/eNote-GmbH/Legato

Ekmelos
http://www.ekmelic-music.org/en/extra/ekmelos.htm
(should be smufl compliant, but does not work correctly on my system)

Free (unknown licence)

Cap1800
remapped by Nor Eddine Bahha (Norfonts)
download cap1800.zip from https://forums.steinberg.net/t/1800-style-font/763178/6

Commercial Fonts

Norfonts:
https://norfonts.ma/en/product-tag/dorico/

November 2.
https://www.klemm-music.de/notation/november2/en/index.php

Music Type Foundry.
Abraham Lee used to sell Smufl versions of his Lilypond fonts. Personal licences were available at $1.
MTF Arnold
MTF Beethoven
MTF Cadence
MTF Haydn
MTF Scorlatti
Also sold LS Iris by Luis Salgueiro
But the business closed down.
It seems the fonts cannot be obtained anymore.

Copyrighted:

AloisenU and AloisenGrooveU
Fonts used in Overture. No official support for other apps. You’ll have to download the app to get the font, and no JSON file provided.
A json file can be downloaded here: https://notat.io/viewtopic.php?t=259&start=10 => does not work
Try the attached ones

aloisenu_json.zip

AloisenGrooveU_json.zip

Jojo-Schmitz · 2023-03-07T10:23:39Z

Great stuff, thanks a lot!

Spaces in filenames are not an issue on Windows BTW.

Jojo-Schmitz · 2023-03-07T11:39:17Z

+              }
+          }
+
+          bool hasMetadataFile = QFileInfo::exists(fontDirPath + "metadata.json");


Would be nice to allow for <fontname>_metatada.json here (but not making it mandatory), or simply *metadata.json, or even *.json, at least if there is only one?

Yes. As is you cannot have a music font and a text font in the same directory (e.g. Finale Jazz and Finale Jazz text

correction: Bravura has only one metadata.json file for Bravura.otf and BravuraText.otf. so it should be possible.

It indeed should. You just can't have different json files for both
What is strange though: regardless of whether the score has a *Text variant or not, the dialog always shows one

I can't display dynamic, with none of the fonts i tried (e.g. Finale Ash). I need to switch the 'Musical Text Font' to a buildin one.
Can you get this working?

It might be your renaming away the spaces in the filenames. It probably needs the space before the "Text" for the text fonts, see https://github.com/Jojo-Schmitz/MuseScore/pull/82/files#diff-9e3816e63546943283fc7dc1cebdb8edfd0d1ca4bb2f0713a3cfe607308a5ff4R3179-R3180

That does not fix the problem. I checked with FontForge the fonts. The dynamics are in the main font, not in the text font. All present with the correct code, e.g. E52F for ff.
In a local debug build, i see this error: /MuseScore/libmscore/sym.cpp:Ms::ScoreFont::draw: ScoreFont::draw: invalid sym 0 (not sure it is related)
sym.cpp:

if (!isValid(id)) {
if (MScore::useFallbackFont && this != ScoreFont::fallbackFont())
fallbackFont()->draw(id, painter, mag, pos, worldScale);
else
qDebug("ScoreFont::draw: invalid sym %d", int(id));
return;
}
Anyway, for me no fallback to Bravura, at least not for the dynamics.
If i remove Finale Ash, when opening a score with that font, then fallback to Bravura does work.

Ok, i have a workaround.

Change libmscore/sym.h (remove the " Text" extension)
QString correspondingTextFontName() const { return _name; }
QString correspondingTextFontFamily() const { return _family; }

Install the font as a system font.
=> the dynamics from the font are shown.
(does not seem to work with Finale Fonts, but works ok for all others)
This is of course not a real solution....

This was not such a good idea after all.
How do these dynamics work exactly? Obviously not the same way as other elements.

(I added a json file for AloisenGrooveU.)

There is obviously something not working in the code, which i don't understand.

But I have a workaround without changing the code.
-open font with FontForge.
Change name to fontnameText , e.g. cap1800Text
Change Family Name and Name for Humans to "fontname Text" e.g. "cap1800 Text"

Generate Font.
Install the font on the computer as system font.

-You can try with attached cap1800
cap1800Text.zip

Jojo-Schmitz · 2023-03-07T11:41:20Z

+
+      qDebug() << "Found" << userfonts.count() << "user score fonts.";
+
+      // TODO: Check for fonts that duplicate built-in fonts


Allowing duplicates might even be good, if the external one would override the internal one. That would allow for example to load a newer version of Bravura, Leland, without needing to rebuild.

Doesn't even need to override, so you can quickly change between the duplicates and compare.

Jojo-Schmitz · 2023-03-07T11:43:51Z

+      }
+
+      _allScoreFonts = _builtinScoreFonts;
+      _allScoreFonts << _userScoreFonts;


A sepaparator between the builtin fonts and the user fonts would be nice

worldwideweary · 2023-04-09T07:33:25Z

Hey Jojo, to be sure, check to see after making use of a custom font if this thing exports well into PDF/SVG. If I remember correctly, it did not for some fonts (it didn't save the font into it and resulted in rectangles everywhere). Has to do with font-family stuff. If it turns out not to work, I've got a fix somewhere in my local build and can send the code over your way

diedeno · 2023-04-09T08:59:15Z

I tried all existing free smufl fonts, and all exported correctly to pdf.

worldwideweary · 2023-04-09T10:12:04Z

I tried all existing free smufl fonts, and all exported correctly to pdf.

sounds good

diedeno · 2023-04-09T15:49:18Z

Nevertheless, there are problems with the code.
e.g.
-the Text fonts (reverts to Bravura( or Leland) on Windows, on Linux just shows some 'hand' glyphs) see above
-linux bug: directories must be lowercase, without spaces
-some errors in tests

Also, when uploading to musescore.com, tempo looks like" [?] = 120" => the 1/4 note missing and a box displayed.

Jojo-Schmitz · 2023-04-09T16:13:04Z

The failing tests are indeed worrying me and are keeping me from merging the PR
The other issue you mention too, but I don't see them myself

Jojo-Schmitz · 2023-04-22T10:37:30Z

In https://w3c.github.io/smufl/latest/specification/font-metadata-locations.html we find recommendations where SMuFL fonts and metadata files should be stored and being searched for, and how the metadata files should be called.

Seems to make up for a pretty good change to this PR, so I've now implemented it

Jojo-Schmitz · 2023-06-10T19:51:19Z

Seems I found a fix for the mtest failures, I'm just not sure whether it is just band aid...
Before moving that preferences.init(true) to before the mscore->init() (and after having disabled some Q_ASSERT()s to prevent it from crashing, which almost all mtests apparently did) I got this:

Config: Using QtTest library 5.15.2, Qt 5.15.2 (x86_64-little_endian-llp64 shared (dynamic) release build; by GCC 8.1.0), windows 10
QDEBUG : TestTools::initTestCase() Ms::Preferences::checkType: Preference is not of correct type: application/paths/myScoreFonts
QDEBUG : TestTools::initTestCase() Ms::Preferences::checkIfKeyExists: Preference not found: application/paths/myScoreFonts
QDEBUG : TestTools::initTestCase() Ms::Preferences::settings: Preferences are not initialized. Call init() to initialize.

followed by another crash...

Jojo-Schmitz · 2023-06-10T20:14:11Z

@cbjeukendrup That mtest fix might be the last missing part for your https://github.com/cbjeukendrup/MuseScore/tree/custom-music-fonts to make it into Mu4. Maybe someone can come up with a better fix though, one that feels less like band aid...

like: * fixing a typo * re-sorting and addting to `Q_INIT_RECOURCES()` to match CMakeLists.txt Match number and order of fonts with CMakeLists.txt * (re-?)initializing `PREF_APP_PATHS_MYSCOREFONTS` to its default and creating the default directry if it doesn't exust

See https://w3c.github.io/smufl/latest/specification/font-metadata-locations.html

…aces. Partial backport of musescore#17886

Jojo-Schmitz mentioned this pull request Mar 5, 2023

[MU3] Add the possibility to use custom ScoreFonts #75

Closed

Jojo-Schmitz force-pushed the custom-fonts branch from bdf9aa7 to fb90c23 Compare March 5, 2023 13:25

Jojo-Schmitz force-pushed the custom-fonts branch from fb90c23 to 34c7bef Compare March 7, 2023 11:31

Jojo-Schmitz commented Mar 7, 2023

View reviewed changes

Jojo-Schmitz force-pushed the custom-fonts branch from 34c7bef to ae8bf72 Compare March 13, 2023 11:57

Jojo-Schmitz force-pushed the custom-fonts branch from ae8bf72 to 967d702 Compare April 13, 2023 14:29

Jojo-Schmitz force-pushed the custom-fonts branch 3 times, most recently from fb40c92 to 59d9491 Compare April 24, 2023 18:31

Jojo-Schmitz force-pushed the 3.x branch 2 times, most recently from ef71657 to 686ee93 Compare May 15, 2023 12:08

Jojo-Schmitz force-pushed the custom-fonts branch 2 times, most recently from d7ecc2f to fca793b Compare June 10, 2023 18:28

Jojo-Schmitz force-pushed the custom-fonts branch from fca793b to a95c2be Compare June 10, 2023 20:02

Jojo-Schmitz force-pushed the custom-fonts branch from a95c2be to 4034145 Compare June 10, 2023 20:20

Add the possibility to use custom ScoreFonts

978204d

Jojo-Schmitz added 3 commits June 16, 2023 13:37

Honor and use system and user wide fonts outside of MuseScore

18e6bc8

See https://w3c.github.io/smufl/latest/specification/font-metadata-locations.html

Rename files with spaces because bmake does not understand escaped sp…

5e8255d

…aces. Partial backport of musescore#17886

Jojo-Schmitz force-pushed the custom-fonts branch 3 times, most recently from b562d46 to 5e8255d Compare June 16, 2023 11:46

Jojo-Schmitz merged commit b7f6faa into 3.x Jul 5, 2023

Jojo-Schmitz deleted the custom-fonts branch July 5, 2023 16:37


		qDebug() << "Found" << userfonts.count() << "user score fonts.";

		// TODO: Check for fonts that duplicate built-in fonts

Uh oh!

Conversation

Jojo-Schmitz commented Mar 5, 2023

Uh oh!

Jojo-Schmitz commented Mar 5, 2023

Uh oh!

cbjeukendrup commented Mar 5, 2023

Uh oh!

diedeno commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jojo-Schmitz commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jojo-Schmitz Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

diedeno Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

diedeno Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jojo-Schmitz Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

diedeno Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

Jojo-Schmitz Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

diedeno Mar 8, 2023

Choose a reason for hiding this comment

Uh oh!

diedeno Mar 8, 2023

Choose a reason for hiding this comment

Uh oh!

diedeno Mar 9, 2023

Choose a reason for hiding this comment

Uh oh!

diedeno Mar 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jojo-Schmitz Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jojo-Schmitz Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

worldwideweary commented Apr 9, 2023

Uh oh!

diedeno commented Apr 9, 2023

Uh oh!

worldwideweary commented Apr 9, 2023

Uh oh!

diedeno commented Apr 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jojo-Schmitz commented Apr 9, 2023

Uh oh!

Jojo-Schmitz commented Apr 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jojo-Schmitz commented Jun 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jojo-Schmitz commented Jun 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

diedeno commented Mar 7, 2023 •

edited

Loading

Jojo-Schmitz commented Mar 7, 2023 •

edited

Loading

Jojo-Schmitz Mar 7, 2023 •

edited

Loading

diedeno Mar 7, 2023 •

edited

Loading

Jojo-Schmitz Mar 7, 2023 •

edited

Loading

Jojo-Schmitz Mar 8, 2023 •

edited

Loading

diedeno Mar 12, 2023 •

edited

Loading

Jojo-Schmitz Mar 7, 2023 •

edited

Loading

diedeno commented Apr 9, 2023 •

edited

Loading

Jojo-Schmitz commented Apr 22, 2023 •

edited

Loading

Jojo-Schmitz commented Jun 10, 2023 •

edited

Loading