Support for albums by lyrra · Pull Request #79 · Jojo-Schmitz/MuseScore

lyrra · 2022-09-09T13:44:23Z

Draft, TBD before PR:

Would be good to have this tested by others.
Also it'd be great to get @SKefalidis' official blessing and review

Current bugs (to be fixed):

crash if closing score
crash if closing album (in album-manager) FIXED in f184fa8
crash if closing album (in album-manager) IF two identical scores are in album
crash if "save album" FIXED in 118b96c
~~crash if exiting~~ (seems not related to this PR)
Writes album properties in an non-album mscx file

(squashed all of Sergios - Anestis Kefalidis patches (from musescore#6145), and then rebased onto 3.x)
~~(it compiles almost on mingw, (get undefined reference to `__stack_chk_fail', something with -fstack-protector))~~
Compiles in a clean build.

fixed currentScoreView updated correctly when switching between excerpts

fixed crash on close album

possible fix-workaround for session restore related crashes

fix paint crash

fix albummanagerdialog with no album loaded

fixed albummanager window calls hide event when changing workspace

drawFrontCover

album title loaded

modified PR musescore#6352

contents pages

fixed crash when adding scores with different instrumentation on new album + playback fix

read + collect_artifacts

enable albumBreaks test

default pause and mass change pause

fixed problems related to restore session? (finally?)

codestyle

use albumScores() instead of x->score

tests for legacy albums

simplified and improved playback control

fixed seq crash

fixed restore session

export parts

at last good playback!!!

fixed crashes related to deleted Album pages

codestyle

cleanup + small things

fix build failure + codestyle

forgot this file

fixed mtests

fixed mtest failure

readme

more cleanup and shorter mtest-scores

forgot this again

correct undo

fixed various issues

updateContents when disabling, crash fixes, drawFrontCover in .msca

disabled Album Manager playback

updated tests

crash fixes

fixed warning + less doLayout calls

fixed parts editing + shadownote for parts

comments

codestyle

rename and comments

a few got left behind

codestyle

rename, delete old code, simplify

codestyle

a bunch of contents and renames

forgot a couple of things

updated text and readme

changed how scores are deleted and forgot this

fix crash by resetting tempScoreTabindex when closing an album

another small fix

fix crash when drag&drop with disabled movements, added support for enabling/disabling for parts, various other improvements

readme

removed text

fixed editing parts and updating the view when editing them

parts scoreview constraints

final touches

readme

codestyle

fix travis failure

FIRST COMMIT AFTER GOOGLE SUMMER OF CODE:
Added tabstops and cleaned ui file, again

text styles for front cover and contents wip

text styles for front cover and contents

fixed rebase

removed unused variable

codestyle

fixed build failure

preferences

Jojo-Schmitz · 2023-12-02T12:33:34Z

And now a merge conflict to resolve (that file had been removed just now)

lyrra · 2023-12-02T12:43:34Z

2 mtests fail now, apparently on some added tests, should be easy to fix, by adding the corresponding lines

OTOH: why are those needed, if not deviating from the default? IIRC we don't write default values into mscx files

Looking at the surrounding values of other settings, it seems it is writing default values.
What is more worrisome is why we are writing albums key/vals at all in an non-album mscx file.

Jojo-Schmitz · 2024-01-24T21:08:36Z

mtest failures now, crashes actually

lyrra · 2024-01-24T21:54:18Z

mtest failures now, crashes actually

Thanks for the heads-up! pushed fixes (order in style.cpp must be same as in types.h)

Jojo-Schmitz · 2024-06-30T16:05:57Z

+           <string notr="true"/>
+          </property>
+          <property name="icon">
+           <iconset resource="../../../../../../../tmp/QtCreator-FLYAKj/qtc-cmake-rKuWjOTJ/mscore/musescore_qmlcache.qrc">


Jojo-Schmitz · 2024-06-30T16:06:16Z

+           <string notr="true"/>
+          </property>
+          <property name="icon">
+           <iconset resource="../../../../../../../tmp/QtCreator-FLYAKj/qtc-cmake-rKuWjOTJ/mscore/musescore_qmlcache.qrc">


Jojo-Schmitz · 2024-06-30T16:13:40Z

The mtest reveal that these settings are (expected to be)

      <albumFrontTitleFontSize>10</albumFrontTitleFontSize>
      <albumFrontComposerFontSize>10</albumFrontComposerFontSize>
      <albumFrontLyricistFontSize>10</albumFrontLyricistFontSize>
      <albumContentsTitleFontSize>10</albumContentsTitleFontSize>
      <albumContentsTextFontSize>10</albumContentsTextFontSize>

in the mtest scores.
But as per style.cpp they are 36, 16, 16,24 and 14, repectively. Question now is where that 10 stems from and why.
I don't see wherte and why that happens

lyrra · 2026-01-15T22:27:06Z

crash when 1) switch to album mode 2) change album title

#5  0x00007ffff5490024 in qt_assert(char const*, char const*, int) () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x0000555556511f8d in Ms::toVBox (e=0x55555b5a1880) at libmscore/scoreElement.h:524
#7  0x000055555651857d in Ms::Album::updateFrontCover (this=0x55555b52e080) at libmscore/album.cpp:1154

Jojo-Schmitz · 2026-01-16T07:53:38Z

Could you please rebase?

fixed currentScoreView updated correctly when switching between excerpts fixed crash on close album possible fix-workaround for session restore related crashes fix paint crash fix albummanagerdialog with no album loaded fixed albummanager window calls hide event when changing workspace drawFrontCover album title loaded modified PR musescore#6352 contents pages fixed crash when adding scores with different instrumentation on new album + playback fix read + collect_artifacts enable albumBreaks test default pause and mass change pause fixed problems related to restore session? (finally?) codestyle use albumScores() instead of x->score tests for legacy albums simplified and improved playback control fixed seq crash fixed restore session export parts at last good playback!!! fixed crashes related to deleted Album pages codestyle cleanup + small things fix build failure + codestyle forgot this file fixed mtests fixed mtest failure readme more cleanup and shorter mtest-scores forgot this again correct undo fixed various issues updateContents when disabling, crash fixes, drawFrontCover in .msca disabled Album Manager playback updated tests crash fixes fixed warning + less doLayout calls fixed parts editing + shadownote for parts comments codestyle rename and comments a few got left behind codestyle rename, delete old code, simplify codestyle a bunch of contents and renames forgot a couple of things updated text and readme changed how scores are deleted and forgot this fix crash by resetting tempScoreTabindex when closing an album another small fix fix crash when drag&drop with disabled movements, added support for enabling/disabling for parts, various other improvements readme removed text fixed editing parts and updating the view when editing them parts scoreview constraints final touches readme codestyle fix travis failure FIRST COMMIT AFTER GOOGLE SUMMER OF CODE:\ Added tabstops and cleaned ui file, again text styles for front cover and contents wip text styles for front cover and contents fixed rebase removed unused variable codestyle fixed build failure preferences

not sure if these changes to the reference-scores are valid, or if the albums-changes are wrongly causing them.

(squash) with patch: * albums: mtest musicxml default album-font-sizes

album fontsize is implicitly tucked on

Jojo-Schmitz · 2026-07-06T10:48:07Z

@lyrra mind to rebase once again?

Jojo-Schmitz force-pushed the master-to-3.x branch from e11375e to 2215182 Compare October 2, 2022 11:56

Jojo-Schmitz force-pushed the master-to-3.x branch from 2215182 to c752dd4 Compare November 20, 2022 15:20

Jojo-Schmitz force-pushed the master-to-3.x branch 12 times, most recently from eecf045 to d9c22dd Compare December 7, 2022 09:04

Jojo-Schmitz force-pushed the master-to-3.x branch 5 times, most recently from 5e20b62 to 8f1e5c8 Compare December 7, 2022 18:00

Jojo-Schmitz force-pushed the master-to-3.x branch 4 times, most recently from 1155017 to e126f11 Compare January 12, 2023 12:16

Jojo-Schmitz force-pushed the master-to-3.x branch 7 times, most recently from 64b3e60 to aa9ba2e Compare January 18, 2023 12:13

Jojo-Schmitz reviewed Dec 1, 2023

View reviewed changes

Comment thread mscore/musescore.cpp Outdated

Jojo-Schmitz reviewed Dec 1, 2023

View reviewed changes

Comment thread mscore/file.cpp Outdated

Jojo-Schmitz reviewed Dec 1, 2023

View reviewed changes

Comment thread mscore/musescore.cpp Outdated

Jojo-Schmitz reviewed Dec 1, 2023

View reviewed changes

Comment thread mscore/musescore.cpp Outdated

Jojo-Schmitz reviewed Jun 30, 2024

View reviewed changes

SKefalidis and others added 16 commits January 16, 2026 22:51

bugfix, check album is set (isAlbum)

2e0479e

albums bugfix: remove dead pages

949d916

albums: mtest musicxml default album-font-sizes

e090dd2

albums: code-formatting

51cea52

bugfix: ensure currentScore->systems is not empty

fb0cfbf

albums: mtest update musescore-version

660cb88

UNVERIFIED albums: mtest updates

879c8e0

not sure if these changes to the reference-scores are valid, or if the albums-changes are wrongly causing them.

albums: bugfix null-check m_topMovement

4be156e

indent fixes

725b301

music-xml font-sizes

bc940c7

(squash) with patch: * albums: mtest musicxml default album-font-sizes

fix mtest

b7cfcd1

album fontsize is implicitly tucked on

cant set title to non-existing album

b4e8ff0

album title edits dont access front cover VBox if null

8dc4b2a

cmake: fix mtest

6693e64

fix rebase text.h

660c39e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support for albums#79

Support for albums#79
lyrra wants to merge 16 commits into
Jojo-Schmitz:3.xfrom
lyrra:albums3x

lyrra commented Sep 9, 2022 •

edited by Jojo-Schmitz

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jojo-Schmitz commented Dec 2, 2023 •

edited

Loading

Uh oh!

lyrra commented Dec 2, 2023

Uh oh!

Jojo-Schmitz commented Jan 24, 2024

Uh oh!

lyrra commented Jan 24, 2024 •

edited

Loading

Uh oh!

Jojo-Schmitz Jun 30, 2024

Uh oh!

Jojo-Schmitz Jun 30, 2024

Uh oh!

Jojo-Schmitz commented Jun 30, 2024

Uh oh!

lyrra commented Jan 15, 2026

Uh oh!

Jojo-Schmitz commented Jan 16, 2026

Uh oh!

Jojo-Schmitz commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

lyrra commented Sep 9, 2022 • edited by Jojo-Schmitz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jojo-Schmitz commented Dec 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lyrra commented Dec 2, 2023

Uh oh!

Jojo-Schmitz commented Jan 24, 2024

Uh oh!

lyrra commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jojo-Schmitz Jun 30, 2024

Choose a reason for hiding this comment

Uh oh!

Jojo-Schmitz Jun 30, 2024

Choose a reason for hiding this comment

Uh oh!

Jojo-Schmitz commented Jun 30, 2024

Uh oh!

lyrra commented Jan 15, 2026

Uh oh!

Jojo-Schmitz commented Jan 16, 2026

Uh oh!

Jojo-Schmitz commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lyrra commented Sep 9, 2022 •

edited by Jojo-Schmitz

Loading

Jojo-Schmitz commented Dec 2, 2023 •

edited

Loading

lyrra commented Jan 24, 2024 •

edited

Loading