Feature/notification refactor phase 1#246
Draft
Johnetordoff wants to merge 39 commits into
Draft
Conversation
…/feature/osfgroup [ENG-7934] OSF Notifications Refactor
…/feature/ENG-7908-remove-meetings-comments-and-osf-groups-notifications [ENG-7908] Remove Meetings, Comments and OSF Groups Notifications
Johnetordoff
force-pushed
the
feature/notification-refactor-phase-1
branch
from
May 22, 2025 14:38
b87f2d9 to
10eee30
Compare
…onfirm-user Fix issue where not having any external identities caused a 500
…ience#11140) ## Purpose adds new relationship for collections a node is in. ## Changes - splits up node detail tests into more workable files <500 that are more atomic - add related view for collection to nodes detail - adds tests ## Ticket https://openscience.atlassian.net/browse/ENG-7966
…ForOpenScience#11158) ## Purpose - Add ArtifactOutcome attributes to linked registrations ## Changes - add annotations to linked registration views - add test cases - split up tests to keep < 500 ln, clean them up and make more atomic ## Ticket https://openscience.atlassian.net/browse/ENG-8148
…ght exception (CenterForOpenScience#11161) ## Purpose If user email already existed the error was uncaught. ## Changes - adds change to catch 400 error - adds test case.
Johnetordoff
force-pushed
the
feature/notification-refactor-phase-1
branch
from
June 2, 2025 15:55
7bab04d to
4892afb
Compare
…OpenScience/osf.io into feature/notification-refactor-phase-1 * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: Clean up tests Clean up tests Clean up imports Remove Meetings, Comments and OSF Groups Notifications remove osf groups remove osf groups remove osf groups remove osf groups remove osf groups # Conflicts: # api_tests/nodes/views/test_node_detail.py # api_tests/nodes/views/test_node_linked_registrations.py # framework/auth/oauth_scopes.py # tests/test_registrations/test_retractions.py
…hub.com/bodintsov/osf.io into feature/notification-refactor-phase-1 * 'feature/remove-remaining-quickiles-code' of https://github.com/bodintsov/osf.io: flake8 fixed tests remove quickfiles
Johnetordoff
force-pushed
the
feature/notification-refactor-phase-1
branch
from
June 3, 2025 18:47
05d1263 to
1a2f7c1
Compare
…ap-Zherebetskyi/osf.io into feature/notification-refactor-phase-1 * 'feature/remove_test_speed-up' of https://github.com/Ostap-Zherebetskyi/osf.io: update mails mock Update send_mail mocks
Johnetordoff
force-pushed
the
feature/notification-refactor-phase-1
branch
from
June 3, 2025 19:00
9fa911c to
013d422
Compare
## Purpose Fix bug for providers that use hybrid moderation. https://staging-sentry2.cos.io/organizations/cos/issues/7583/?query=is%3Aunresolved&referrer=issue-stream&stream_index=2 ## Changes - adds minor logic changes to declarative code. - adds test cases for hybrid moderation ##Ticket https://openscience.atlassian.net/browse/ENG-7976
…ns - BE (CenterForOpenScience#11174) * [ENG-8147] Manually assign GUID when creating registrations and preprints (CenterForOpenScience#11160) * [ENG-8145] Added manual doi setting for registrations and preprints (CenterForOpenScience#11162) * [ENG-8145] Update manual DOI assignment for Preprints (CenterForOpenScience#11172) * Revert unnecessary changes in generate_guid() (c46e21b) * Allow blank value when manually setting GUID and DOI (2b09d94) * [ENG-8185] Unit tests for Manual GUID and DOI (CenterForOpenScience#11175)
Manual GUID & DOI assignment during Preprint and Registration Creation
…versions with _v1 (CenterForOpenScience#11154) ## Purpose do not mint _v1 doi if legacy one exists ## Changes - make sure that CrossrefClient works well with legacy DOIs - don't send request to crossref when check_crossref_dois if no DOIs were selected - check only published preprints when mint_doi_on_crossref_fail ## Ticket https://openscience.atlassian.net/browse/ENG-7870
…enterForOpenScience#11169) ## Purpose When user adds a component to a node that has addons with files and registers it, the node doesn't have any archived files. It happens because the child nodes are the first ones to be registered and if a child doesn't have any addons, this empty list would be saved in `request.gv_addons` attribute that is reused for all other parents and children to avoid making redundant requests to GV. However each child and parent may have its own collection of addons. ## Changes Removed caching ## QA Notes Would be nice to test what happens when a child node has addons with files, but its parent hasn't. Will the parent inherit archived addons files or not? ## Ticket https://openscience.atlassian.net/browse/ENG-8048
## Purpose `_get_addon_from_gv` iterates through None when service is not found in `_get_addons_from_gv_without_caching` ## Changes Replace None by an empty list
This reverts commit 5c918fa.
…ce/revert-11192-fix/ENG-8048-none Revert "[ENG-8048_2] fixed None issue during iteration"
…ndants (…" This reverts commit 7d752ac.
…ce/revert-11169-fix/ENG-8048 Revert "[ENG-8048] Remove caching to avoid incorrect results for ascendants"
…cience/osf.io into feature/notification-refactor-phase-1 * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: Revert "[ENG-8048] Remove caching to avoid incorrect results for ascendants (…" Revert "fixed None issue when iterate (CenterForOpenScience#11192)" fixed None issue when iterate (CenterForOpenScience#11192) [ENG-8048] Remove caching to avoid incorrect results for ascendants (CenterForOpenScience#11169) [ENG-7870] Crossref DOIs not minting with _v1, OSF is displaying DOI versions with _v1 (CenterForOpenScience#11154) Update changelog and package.json [ENG-8145] [ENG-8147] Manual DOI and GUID for Preprints & Registrations - BE (CenterForOpenScience#11174) Update hybrid values for new workflow check (CenterForOpenScience#11166)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket