Remove registration metadata#245
Draft
Johnetordoff wants to merge 12 commits into
Draft
Conversation
into develop * 'develop' of https://github.com/CenterForOpenScience/osf.io: add grade levels category for collections (CenterForOpenScience#11064)
into develop * 'develop' of https://github.com/CenterForOpenScience/osf.io: (61 commits) Update changelog and package.json [ENG-7698] Fix permission for contributor, when accepting access request #2 (CenterForOpenScience#11077) Add disable meetings feature Fix institutional access request for contributor upgrade cache and ubuntu versions to avoid GHA brownouts (CenterForOpenScience#11009) [ENG-7461] Fix bug with Article DOI for Preprints (CenterForOpenScience#11068) [ENG-7472] Fix/preprint no option to resubmit (CenterForOpenScience#11069) [ENG-7714] Use retry instead of sleep (CenterForOpenScience#11067) Implement flag to disable comment updates and add corresponding tests [ENG-7707] A specific preprint is not found but should be (CenterForOpenScience#11059) Add feature flag to disable comments and update related tests [ENG-7461] Fix Validation Issues with Article DOIs (CenterForOpenScience#11062) [ENG-6422] added management command to log all write actions to given table (CenterForOpenScience#11057) add CSRF protection and throttle classes; update tests refactor external login serializer and view to use session data for user information add external login unit tests removed campaigns fix tests Add external login serializer and view for first-time OAuth users Fix permission for contributor, when accept access request ...
…nce#11081) ## Purpose Allow integrator to change the scope of their PAT. So that full token read/write scopes fall under full_write scope. ## Changes - clean of test_token_detail test, splitting them up into files <500 ln - Add a test for editing PAT scopes with a PAT - Add permission to make possible: https://github.com/CenterForOpenScience/osf.io/pull/11070/files#r2025067543 ## Ticket https://openscience.atlassian.net/browse/ENG-7761
…n't a contributor (CenterForOpenScience#11084) ## Purpose `set_published` method checks if this action is performed by admin contributor, however admins in admin app should be able to perform this action without the permission ## Changes Handle this case with an additional parameter in method because if we add check like "if is_admin or is_admin_contributor" there may be a case when admin user opens preprint and publishes it via API that he shouldn't be able to do ## Ticket https://openscience.atlassian.net/browse/ENG-7749
CenterForOpenScience#11083) ## Purpose Contributors ordering in registration metadata is not updated ## Changes `index` field is read only if we inherit from `NodeContributorsSerializer`. The new one `NodeContributorDetailSerializer` overrides this field to be editable and inherits from `NodeContributorsSerializer` Also contributors ordering is different on registration metadata and metadata editing pages, thus it was fixed by adding the ordering attribute Also added tests ## Ticket https://openscience.atlassian.net/browse/ENG-7751
* ENG-5751 remove old keen logic * add migration * remove legacy keen from metrics .js (maybe another keen logic is also needed to be removed in the files) * remove dashboard keen (it is not used in any views) * ENG-5751 code updates * ENG-5751 remove keen dependency from poetry * ENG-5751 code updates * code updates * ENG-5751 resolve PR comments * ENG-5751 add default '' analytics_key * ENG-5751 remove base_analytics.html * add keen-dashboards.css * fix/ENG-5751 it seems 'keen' is used in base mako files and keen js rely on it and it is not needed to be deleted * fix/ENG-5751 resolve PR comments (not confident about 'getUniqueId' implementation https://stackoverflow.com/questions/18230217/javascript-generate-a-random-number-within-a-range-using-crypto-getrandomvalues ) * remove keen-tracking * update getUniqueId * fix/ENG-5751 PR comments related updates * fix/ENG-5751 PR comments related updates * remove geoip from deps and location code from app * PR comment related updates CenterForOpenScience#10992 (comment) * fix migrations conflicts * a few tidy-ups: * Relocate code changes in api.nodes.serializers to be more compact when squished. * Really delete `cumulative_plos_metrics.py`. Per Eric's comments on Slack, we no longer need this. * Remove `cumulative_plos_metrics.py`-related config from website.settings.defaults.py * Add attributive comments for borrowed code in metrics library. --------- Co-authored-by: Fitz Elliott <fitz@cos.io>
…ence#11091) ## Purpose In metadata we return authors' names as full names. We should use this format instead: "{family name}, {given name}" Also added givenName and familyName in JSON-LD schema ## Changes Updated function that generates names, added `given_name` attribute when serialize contributors in mako templates ## Ticket https://openscience.atlassian.net/browse/ENG-7799
…us (CenterForOpenScience#11087) ## Purpose fix preprint creator cannot remove bibliographic citation status ## Changes - move restriction logic to serializer field validator to validate only permission field during any updates: PATCH, PUT - add more tests ## Ticket https://openscience.atlassian.net/browse/ENG-7750
…orOpenScience#11085) ## Purpose Update SHARE index when collection submission is created ## Changes - add update_share() call - minor collection submission transitions refactor to remove redundant transitions ## QA Notes This PR won't fix collection submission indexes that were not created, but will prevent such situation in the future ## Ticket https://openscience.atlassian.net/browse/ENG-7289
…cience/osf.io into remove-registration-metadata * 'feature/pbs-25-07' of https://github.com/CenterForOpenScience/osf.io: [ENG-7289] Fix Search Index Discrepancy in Collection Facets (CenterForOpenScience#11085) [ENG-7750] Preprint creator cannot remove bibliographic citation status (CenterForOpenScience#11087) [ENG-7799] Update authors' names format in metadata (CenterForOpenScience#11091) [ENG-5751] remove old keen logic (CenterForOpenScience#11082) [ENG-7751] Fixed contributors reordering on registration metadata page (CenterForOpenScience#11083) [ENG-7749] admin user can publish preprint in admin app even if he isn't a contributor (CenterForOpenScience#11084) [ENG-7761] Edit scopes with Personal Access Tokens (CenterForOpenScience#11081)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket