Update README.md#2
Open
JohnAmadeo wants to merge 1 commit into
Open
Conversation
Owner
Author
|
1234 |
Owner
Author
|
This is an issue comment |
Owner
Author
|
This is an issue comment v2 |
Owner
Author
|
This is an issue comment v4 |
Owner
Author
|
This is an issue comment v5 |
JohnAmadeo
commented
Oct 29, 2025
| # Intro (for people new to Go) | ||
| # Intro (for people new to Golang) | ||
| - Check out [A Tour of Go](https://tour.golang.org/welcome/1) to learn Go syntax | ||
| - Download Go [Downloads](https://golang.org/dl/) |
Owner
Author
There was a problem hiding this comment.
This is an inline comment, created by clicking 'Comment' instead of 'Start a review'
JohnAmadeo
commented
Oct 29, 2025
Owner
Author
|
This is an edited issue comment v5 |
JohnAmadeo
commented
Oct 29, 2025
| # Intro (for people new to Go) | ||
| # Intro (for people new to Golang) | ||
| - Check out [A Tour of Go](https://tour.golang.org/welcome/1) to learn Go syntax | ||
| - Download Go [Downloads](https://golang.org/dl/) |
Owner
Author
There was a problem hiding this comment.
This is a inline comment, created with 'Start a review'
JohnAmadeo
commented
Oct 29, 2025
JohnAmadeo
left a comment
JohnAmadeo
left a comment
Owner
Author
There was a problem hiding this comment.
This is a body comment
| # Intro (for people new to Go) | ||
| # Intro (for people new to Golang) | ||
| - Check out [A Tour of Go](https://tour.golang.org/welcome/1) to learn Go syntax | ||
| - Download Go [Downloads](https://golang.org/dl/) |
Owner
Author
There was a problem hiding this comment.
This is an inline comment 1
| @@ -1,4 +1,4 @@ | |||
| # Intro (for people new to Go) | |||
| # Intro (for people new to Golang) | |||
| - Check out [A Tour of Go](https://tour.golang.org/welcome/1) to learn Go syntax | |||
Owner
Author
There was a problem hiding this comment.
This is an inline comment 2
| @@ -1,4 +1,4 @@ | |||
| # Intro (for people new to Go) | |||
| # Intro (for people new to Golang) | |||
Owner
Author
There was a problem hiding this comment.
This is an inline comment 3
JohnAmadeo
commented
Oct 29, 2025
| @@ -1,4 +1,4 @@ | |||
| # Intro (for people new to Go) | |||
| # Intro (for people new to Golang) | |||
Owner
Author
There was a problem hiding this comment.
This is an inline comment
mcode-app Bot
referenced
this pull request
in shuertaMC/mealbot-sergio-test
Jan 23, 2026
…e serving
This commit implements the core FastAPI application infrastructure including:
**FastAPI Application Setup:**
- Created app/main.py with FastAPI instance configured with title="Mealbot API"
- OpenAPI documentation automatically available at /docs and /openapi.json
- Root endpoint (/) returns welcome message with API info
- Health check endpoint (/health) returns {"status": "ok"}
**CORS Middleware:**
- Configured CORSMiddleware to match Go implementation behavior from cors.go
- Allows all origins (["*"]) to mirror the Origin header behavior
- Allows credentials (allow_credentials=True)
- Allows methods: GET, POST, DELETE (matching cors.go line 21)
- Allows headers: Authorization, Content-Type, Origin, Accept, token (matching cors.go line 9)
- Handles OPTIONS preflight requests automatically
**Static File Serving:**
- Mounted StaticFiles at /static path (resolves Design Decision #5)
- Copied privacy.html and sample.csv from source repository to dst/static/
- Used Path-based directory resolution for portability
- Static files accessible at /static/privacy.html and /static/sample.csv
**Testing:**
- Created comprehensive test suite in tests/test_main.py
- 14 tests covering health endpoint, root endpoint, CORS headers, static files, and OpenAPI docs
- All tests pass successfully
**Security:**
- Created .gitleaks.toml configuration to allowlist test fixtures
- Test RSA keys in tests/test_auth.py (from Task #2) are properly documented as synthetic keys
- These are test-only fixtures for JWT authentication testing that should never be used in production
- Gitleaks scanner passes with no false positives
**Implementation Note:**
Settings are not loaded at module level in main.py to avoid validation errors during testing. This allows tests to run without requiring all environment variables to be set.
The application successfully starts with `uvicorn app.main:app --port 8080` and all functionality is verified through automated tests.
Milestone No.: 1
Task No.: 3
Task ID: 9
mcode-app Bot
referenced
this pull request
in shuertaMC/mealbot-sergio-test
Jan 23, 2026
…e serving: merge from mealbot-sergio-test-milestone_1-task_3-ab86fa
This commit implements the core FastAPI application infrastructure including:
**FastAPI Application Setup:**
- Created app/main.py with FastAPI instance configured with title="Mealbot API"
- OpenAPI documentation automatically available at /docs and /openapi.json
- Root endpoint (/) returns welcome message with API info
- Health check endpoint (/health) returns {"status": "ok"}
**CORS Middleware:**
- Configured CORSMiddleware to match Go implementation behavior from cors.go
- Allows all origins (["*"]) to mirror the Origin header behavior
- Allows credentials (allow_credentials=True)
- Allows methods: GET, POST, DELETE (matching cors.go line 21)
- Allows headers: Authorization, Content-Type, Origin, Accept, token (matching cors.go line 9)
- Handles OPTIONS preflight requests automatically
**Static File Serving:**
- Mounted StaticFiles at /static path (resolves Design Decision #5)
- Copied privacy.html and sample.csv from source repository to dst/static/
- Used Path-based directory resolution for portability
- Static files accessible at /static/privacy.html and /static/sample.csv
**Testing:**
- Created comprehensive test suite in tests/test_main.py
- 14 tests covering health endpoint, root endpoint, CORS headers, static files, and OpenAPI docs
- All tests pass successfully
**Security:**
- Created .gitleaks.toml configuration to allowlist test fixtures
- Test RSA keys in tests/test_auth.py (from Task #2) are properly documented as synthetic keys
- These are test-only fixtures for JWT authentication testing that should never be used in production
- Gitleaks scanner passes with no false positives
**Implementation Note:**
Settings are not loaded at module level in main.py to avoid validation errors during testing. This allows tests to run without requiring all environment variables to be set.
The application successfully starts with `uvicorn app.main:app --port 8080` and all functionality is verified through automated tests.
Milestone No.: 1
Task No.: 3
Task ID: 9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.