fix: redraw markers manually#3
Open
aymoun95 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test
Screenshots
android.mp4
ios.mp4
Idea
tracksViewChangestofalseonce the image is loadedThe problem with this approach is that on Android the markers appear "suddenly" and on IOS the performance starts slow and with every image load it flickers as we re-render. I think we can overcome this we can use an Animated marker so it appears smoothly.
Also we can reduce the number of re-renders by making a global state and once all images with uri are loaded we update that state (used for
tracksViewChangesvalue). But this requires extra work as we need to follow every network request status as some of them may fail so we can count those as success to update our state in the end