Skip to content

Read and analyze Agent Skills documentation#25

Draft
Jobayer-c8 wants to merge 1 commit into
mainfrom
agent-skills-docs-read-2441976735770718052
Draft

Read and analyze Agent Skills documentation#25
Jobayer-c8 wants to merge 1 commit into
mainfrom
agent-skills-docs-read-2441976735770718052

Conversation

@Jobayer-c8

Copy link
Copy Markdown
Owner

I have retrieved and analyzed the full content of home.md and llms.txt from agentskills.io. I am now ready to answer any questions about Agent Skills.

Summary of Agent Skills:

  • A standardized, lightweight format for extending AI agent capabilities.
  • A skill consists of a folder with a mandatory SKILL.md file (metadata and instructions) and optional scripts, references, and assets.
  • Uses a "progressive disclosure" model:
    1. Discovery: Loading name and description for relevance.
    2. Activation: Reading full instructions when a task matches.
    3. Execution: Following instructions and running bundled code.
  • Supported by a wide range of agents and tools including Claude, VS Code, Cursor, and many others.

PR created automatically by Jules for task 2441976735770718052 started by @Jobayer-c8

Co-authored-by: Jobayer-c8 <290884056+Jobayer-c8@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the main documentation pages for Agent Skills, including home.md and llms.txt. In home.md, a React-based LogoCarousel component is added to showcase various clients. The review feedback points out two important issues in this component: first, useState and useEffect are used without being imported, which will cause a runtime error; second, defining the nested Logo component inside LogoCarousel is a React anti-pattern that causes unnecessary recreations on every render, and should be inlined instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread home.md
Comment on lines +9 to +11
export const LogoCarousel = ({clients}) => {
const [shuffled, setShuffled] = useState(clients);
useEffect(() => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The React hooks useState and useEffect are used in the LogoCarousel component but are not imported. This will cause a runtime ReferenceError when rendering the MDX page. Please import them from 'react' at the top of the file.

Suggested change
export const LogoCarousel = ({clients}) => {
const [shuffled, setShuffled] = useState(clients);
useEffect(() => {
import { useState, useEffect } from 'react';
export const LogoCarousel = ({clients}) => {
const [shuffled, setShuffled] = useState(clients);
useEffect(() => {

Comment thread home.md
Comment on lines +27 to +40
const Logo = ({client}) => <a href={client.url} className="block no-underline border-none w-full h-full">
<img className="block dark:hidden object-contain w-full h-full !my-0" src={client.lightSrc} alt={client.name} noZoom />
<img className="hidden dark:block object-contain w-full h-full !my-0" src={client.darkSrc} alt={client.name} noZoom />
</a>;
return <div className="logo-carousel">
<div className="logo-carousel-track" style={{
animation: `logo-scroll ${cycleDuration}s linear infinite`
}}>
{doubled.map((client, i) => <div key={`${client.name}-${i}`} style={{
width: 150 * (client.scale || 1),
maxWidth: "100%"
}}>
<Logo client={client} />
</div>)}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Defining the Logo component inside the LogoCarousel component causes it to be recreated on every render of LogoCarousel. This is a React anti-pattern that can lead to performance issues and unnecessary DOM updates. It is better to inline the JSX directly inside the .map() loop.

Suggested change
const Logo = ({client}) => <a href={client.url} className="block no-underline border-none w-full h-full">
<img className="block dark:hidden object-contain w-full h-full !my-0" src={client.lightSrc} alt={client.name} noZoom />
<img className="hidden dark:block object-contain w-full h-full !my-0" src={client.darkSrc} alt={client.name} noZoom />
</a>;
return <div className="logo-carousel">
<div className="logo-carousel-track" style={{
animation: `logo-scroll ${cycleDuration}s linear infinite`
}}>
{doubled.map((client, i) => <div key={`${client.name}-${i}`} style={{
width: 150 * (client.scale || 1),
maxWidth: "100%"
}}>
<Logo client={client} />
</div>)}
return <div className="logo-carousel">
<div className="logo-carousel-track" style={{
animation: `logo-scroll ${cycleDuration}s linear infinite`
}}>
{doubled.map((client, i) => <div key={`${client.name}-${i}`} style={{
width: 150 * (client.scale || 1),
maxWidth: "100%"
}}>
<a href={client.url} className="block no-underline border-none w-full h-full">
<img className="block dark:hidden object-contain w-full h-full !my-0" src={client.lightSrc} alt={client.name} noZoom />
<img className="hidden dark:block object-contain w-full h-full !my-0" src={client.darkSrc} alt={client.name} noZoom />
</a>
</div>)}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant