Support CBT and CHT control sequences in the emulator and terminal model#331
Open
Ayman Bagabas (aymanbagabas) wants to merge 1 commit into
Open
Support CBT and CHT control sequences in the emulator and terminal model#331Ayman Bagabas (aymanbagabas) wants to merge 1 commit into
Ayman Bagabas (aymanbagabas) wants to merge 1 commit into
Conversation
2 tasks
Contributor
Author
|
Sergey Simonchik (@segrey) Let me know if you want me to make any changes 🙂 |
|
As a JetBrains superfan for almost two decades, this issue is a big problem for me. I really hope you will seriously consider addressing this issue soon. |
When a terminal advertises itself as `xterm`, it is expected to support the `CBT` (Cursor Backward Tab). However, JediTerm's emulator did not support this control sequence, which caused some applications to behave incorrectly when running in JediTerm. This commit adds support for the `CBT` control sequence in the `JediEmulator` class, as well as the corresponding `CHT` (Cursor Forward Tab) control sequence. The `Terminal` interface is updated to include methods for finding the previous and next tab stops, and the `JediTerminal` class implements these methods using its existing tabulator functionality. Fixes: JetBrains#328
Ayman Bagabas (aymanbagabas)
force-pushed
the
cbt-cht
branch
from
dc5f512 to
3a21ba7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a terminal advertises itself as
xterm, it is expected to support theCBT(Cursor Backward Tab). However, JediTerm's emulator did not support this control sequence, which caused some applications to behave incorrectly when running in JediTerm.This commit adds support for the
CBTcontrol sequence in theJediEmulatorclass, as well as the correspondingCHT(Cursor Forward Tab) control sequence. TheTerminalinterface is updated to include methods for finding the previous and next tab stops, and theJediTerminalclass implements these methods using its existing tabulator functionality.Fixes: #328