chore: Bump coverlet.collector from 8.0.1 to 10.0.0

build/.editorconfig

@@ -0,0 +1,5 @@
+[*.cs]
+# Nuke build fields use attribute-based reflection injection and cannot follow
+# the standard private field naming convention with underscore prefix.
+dotnet_naming_rule.private_fields_should_start_with_underscore.severity = none
+dotnet_naming_rule.private_static_fields_should_start_with_s_underscore.severity = none

build/Build.cs

@@ -17,7 +17,7 @@
 using static Nuke.Common.Tools.ReportGenerator.ReportGeneratorTasks;
 
 [ShutdownDotNetAfterServerBuild]
-class Build : NukeBuild
+internal class Build : NukeBuild
 {
     /// Support plugins are available for:
     ///   - JetBrains ReSharper        https://nuke.build/resharper
@@ -28,30 +28,30 @@ class Build : NukeBuild
     public static int Main() => Execute<Build>(x => x.Compile);
 
     [Parameter("Configuration to build - Default is 'Debug' (local) or 'Release' (server)")]
-    readonly string Configuration = IsLocalBuild ? "Debug" : "Release";
+    private readonly string Configuration = IsLocalBuild ? "Debug" : "Release";
 
     [Parameter("Enable code coverage collection")]
-    readonly bool CoverageEnabled = true;
+    private readonly bool CoverageEnabled = true;
 
     [Parameter("Verbosity level for build output")]
-    readonly DotNetVerbosity BuildVerbosity = DotNetVerbosity.minimal;
+    private readonly DotNetVerbosity BuildVerbosity = DotNetVerbosity.minimal;
 
     [Solution(GenerateProjects = false)]
-    readonly Solution Solution;
+    private readonly Solution Solution;
 
     [GitVersion(NoFetch = true, Framework = "net10.0")]
     [CanBeNull]
-    readonly GitVersion GitVersion;
+    private readonly GitVersion GitVersion;
 
-    AbsolutePath SourceDirectory => RootDirectory / "src";
-    AbsolutePath TestsDirectory => RootDirectory / "tests";
-    AbsolutePath ArtifactsDirectory => RootDirectory / "artifacts";
-    AbsolutePath TestResultsDirectory => ArtifactsDirectory / "test-results";
-    AbsolutePath CoverageDirectory => ArtifactsDirectory / "coverage";
-    AbsolutePath PublishDirectory => ArtifactsDirectory / "publish";
-    AbsolutePath PackagesDirectory => ArtifactsDirectory / "packages";
+    private AbsolutePath SourceDirectory => RootDirectory / "src";
+    private AbsolutePath TestsDirectory => RootDirectory / "tests";
+    private AbsolutePath ArtifactsDirectory => RootDirectory / "artifacts";
+    private AbsolutePath TestResultsDirectory => ArtifactsDirectory / "test-results";
+    private AbsolutePath CoverageDirectory => ArtifactsDirectory / "coverage";
+    private AbsolutePath PublishDirectory => ArtifactsDirectory / "publish";
+    private AbsolutePath PackagesDirectory => ArtifactsDirectory / "packages";
 
-    Target Clean => _ => _
+    private Target Clean => _ => _
         .Before(Restore)
         .Executes(() =>
         {
@@ -60,14 +60,14 @@ class Build : NukeBuild
             ArtifactsDirectory.CreateOrCleanDirectory();
         });
 
-    Target Restore => _ => _
+    private Target Restore => _ => _
         .Executes(() =>
         {
             DotNetRestore(s => s
                 .SetProjectFile(Solution));
         });
 
-    Target Compile => _ => _
+    private Target Compile => _ => _
         .DependsOn(Restore)
         .Executes(() =>
         {
@@ -81,7 +81,7 @@ class Build : NukeBuild
                 .SetVerbosity(BuildVerbosity));
         });
 
-    Target Test => _ => _
+    private Target Test => _ => _
         .DependsOn(Compile)
         .Produces(TestResultsDirectory / "*.trx")
         .Produces(CoverageDirectory / "*.xml")
@@ -110,7 +110,7 @@ class Build : NukeBuild
             DotNetTest(testSettings);
         });
 
-    Target IntegrationTest => _ => _
+    private Target IntegrationTest => _ => _
         .DependsOn(Compile)
         .Produces(TestResultsDirectory / "integration-*.trx")
         .Executes(() =>
@@ -129,7 +129,7 @@ class Build : NukeBuild
                     .SetProjectFile(project)));
         });
 
-    Target Coverage => _ => _
+    private Target Coverage => _ => _
         .DependsOn(Test)
         .Produces(CoverageDirectory / "*.xml")
         .Executes(() =>
@@ -143,7 +143,7 @@ class Build : NukeBuild
             }
         });
 
-    Target CoverageReport => _ => _
+    private Target CoverageReport => _ => _
         .DependsOn(Coverage)
         .Produces(CoverageDirectory / "report" / "**/*")
         .Executes(() =>
@@ -161,7 +161,7 @@ class Build : NukeBuild
             Log.Information("Coverage report generated: {Report}", CoverageDirectory / "report" / "index.html");
         });
 
-    Target Pack => _ => _
+    private Target Pack => _ => _
         .DependsOn(Compile)
         .Produces(PackagesDirectory / "*.nupkg")
         .Executes(() =>
@@ -176,7 +176,7 @@ class Build : NukeBuild
                 .SetVerbosity(BuildVerbosity));
         });
 
-    Target Publish => _ => _
+    private Target Publish => _ => _
         .DependsOn(Compile)
         .Produces(PublishDirectory / "**/*")
         .Executes(() =>
@@ -199,19 +199,19 @@ class Build : NukeBuild
                     .SetOutput(PublishDirectory / project.Name)));
         });
 
-    Target Format => _ => _
+    private Target Format => _ => _
         .Executes(() =>
         {
             DotNet($"format \"{Solution}\" --verbosity {Verbosity}");
         });
 
-    Target FormatVerify => _ => _
+    private Target FormatVerify => _ => _
         .Executes(() =>
         {
             DotNet($"format \"{Solution}\" --verify-no-changes --verbosity {Verbosity}");
         });
 
-    Target Lint => _ => _
+    private Target Lint => _ => _
         .DependsOn(Restore)
         .Executes(() =>
         {
@@ -224,12 +224,12 @@ class Build : NukeBuild
                 .SetVerbosity(BuildVerbosity));
         });
 
-    Target Default => _ => _
+    private Target Default => _ => _
         .DependsOn(Restore)
         .DependsOn(Compile)
         .DependsOn(Test);
 
-    Target Full => _ => _
+    private Target Full => _ => _
         .DependsOn(Clean)
         .DependsOn(Restore)
         .DependsOn(Compile)
@@ -238,7 +238,7 @@ class Build : NukeBuild
         .DependsOn(Pack)
         .DependsOn(Publish);
 
-    Target CI => _ => _
+    private Target CI => _ => _
         .DependsOn(Clean)
         .DependsOn(Restore)
         .DependsOn(Compile)

src/Core/PokManager.Application/Configuration/ArkConfigurationDefaults.cs

@@ -120,7 +120,7 @@ public static Dictionary<string, ArkConfigSetting> GetDefaults()
             { "bUseSingleplayerSettings", new ArkConfigSetting("False", "Advanced", "Use singleplayer settings multipliers") },
         };
     }
-    
+
     /// <summary>
     /// Represents an ARK configuration setting with metadata.
     /// </summary>
@@ -129,7 +129,7 @@ public class ArkConfigSetting
         public string DefaultValue { get; }
         public string Category { get; }
         public string Description { get; }
-        
+
         public ArkConfigSetting(string defaultValue, string category, string description)
         {
             DefaultValue = defaultValue;

src/Core/PokManager.Application/DependencyInjection/ApplicationServiceRegistration.cs

@@ -1,6 +1,6 @@
-using Microsoft.Extensions.DependencyInjection;
-using FluentValidation;
 using System.Reflection;
+using FluentValidation;
+using Microsoft.Extensions.DependencyInjection;
 
 namespace PokManager.Application.DependencyInjection;
 

src/Core/PokManager.Application/UseCases/InstanceLifecycle/CreateInstance/CreateInstanceRequestValidator.cs

@@ -4,7 +4,7 @@ namespace PokManager.Application.UseCases.InstanceLifecycle.CreateInstance;
 
 public class CreateInstanceRequestValidator : AbstractValidator<CreateInstanceRequest>
 {
-    private static readonly string[] ValidMapNames = new[]
+    private static readonly string[] s_validMapNames = new[]
     {
         "TheIsland",
         "TheCenter",
@@ -34,7 +34,7 @@ public CreateInstanceRequestValidator()
 
         RuleFor(x => x.MapName)
             .NotEmpty().WithMessage("Map name cannot be empty")
-            .Must(BeAValidMapName).WithMessage($"Map name must be one of: {string.Join(", ", ValidMapNames)}");
+            .Must(BeAValidMapName).WithMessage($"Map name must be one of: {string.Join(", ", s_validMapNames)}");
 
         RuleFor(x => x.MaxPlayers)
             .InclusiveBetween(1, 127).WithMessage("Max players must be between 1 and 127");
@@ -71,6 +71,6 @@ public CreateInstanceRequestValidator()
 
     private bool BeAValidMapName(string mapName)
     {
-        return ValidMapNames.Contains(mapName, StringComparer.OrdinalIgnoreCase);
+        return s_validMapNames.Contains(mapName, StringComparer.OrdinalIgnoreCase);
     }
 }

src/Core/PokManager.Application/UseCases/InstanceManagement/SaveWorld/SaveWorldHandler.cs

@@ -1,8 +1,8 @@
+using System.Diagnostics;
 using PokManager.Application.Models;
 using PokManager.Application.Ports;
 using PokManager.Domain.Common;
 using PokManager.Domain.Enumerations;
-using System.Diagnostics;
 
 namespace PokManager.Application.UseCases.InstanceManagement.SaveWorld;
 

src/Core/PokManager.Domain/Entities/Instance.cs

@@ -15,7 +15,7 @@ public class Instance(string instanceId, string sessionName, string mapName, int
     public string? ContainerId { get; set; }
 
     // State transition rules
-    private static readonly Dictionary<InstanceState, HashSet<InstanceState>> AllowedTransitions = new()
+    private static readonly Dictionary<InstanceState, HashSet<InstanceState>> s_allowedTransitions = new()
     {
         [InstanceState.Created] = new() { InstanceState.Starting },
         [InstanceState.Stopped] = new() { InstanceState.Starting, InstanceState.Deleted },
@@ -28,7 +28,7 @@ public class Instance(string instanceId, string sessionName, string mapName, int
 
     public Result<Unit> TransitionTo(InstanceState newState)
     {
-        if (!AllowedTransitions.TryGetValue(State, out var allowedStates))
+        if (!s_allowedTransitions.TryGetValue(State, out var allowedStates))
         {
             return Result.Failure<Unit>($"No transitions defined for state {State}");
         }

src/Core/PokManager.Domain/ValueObjects/BackupId.cs

@@ -5,7 +5,7 @@ namespace PokManager.Domain.ValueObjects;
 
 public sealed class BackupId : IEquatable<BackupId>
 {
-    private static readonly Regex ValidationPattern = new(
+    private static readonly Regex s_validationPattern = new(
         @"^([a-zA-Z0-9_-]+)_backup_(\d{4}-\d{2}-\d{2}_\d{2}-\d{2}-\d{2})$",
         RegexOptions.Compiled);
 
@@ -29,7 +29,7 @@ public static Result<BackupId> Create(string value)
             return Result<BackupId>.Failure("BackupId cannot be empty or whitespace.");
         }
 
-        var match = ValidationPattern.Match(value);
+        var match = s_validationPattern.Match(value);
         if (!match.Success)
         {
             return Result<BackupId>.Failure(

src/Core/PokManager.Domain/ValueObjects/InstanceId.cs

@@ -5,7 +5,7 @@ namespace PokManager.Domain.ValueObjects;
 
 public sealed class InstanceId : IEquatable<InstanceId>
 {
-    private static readonly Regex ValidationPattern = new(@"^[a-zA-Z0-9_-]+$", RegexOptions.Compiled);
+    private static readonly Regex s_validationPattern = new(@"^[a-zA-Z0-9_-]+$", RegexOptions.Compiled);
     private const int MaxLength = 64;
 
     public string Value { get; }
@@ -27,7 +27,7 @@ public static Result<InstanceId> Create(string value)
             return Result<InstanceId>.Failure($"InstanceId cannot exceed {MaxLength} characters.");
         }
 
-        if (!ValidationPattern.IsMatch(value))
+        if (!s_validationPattern.IsMatch(value))
         {
             return Result<InstanceId>.Failure("InstanceId must contain only alphanumeric characters, hyphens, and underscores.");
         }

src/Core/PokManager.Domain/ValueObjects/ServerPassword.cs

@@ -5,7 +5,7 @@ namespace PokManager.Domain.ValueObjects;
 
 public sealed class ServerPassword : IEquatable<ServerPassword>
 {
-    private static readonly Regex ValidationPattern = new(@"^[a-zA-Z0-9]+$", RegexOptions.Compiled);
+    private static readonly Regex s_validationPattern = new(@"^[a-zA-Z0-9]+$", RegexOptions.Compiled);
     private const int MinLength = 4;
     private const int MaxLength = 64;
 
@@ -33,7 +33,7 @@ public static Result<ServerPassword> Create(string value)
             return Result<ServerPassword>.Failure($"ServerPassword cannot exceed {MaxLength} characters.");
         }
 
-        if (!ValidationPattern.IsMatch(value))
+        if (!s_validationPattern.IsMatch(value))
         {
             return Result<ServerPassword>.Failure("ServerPassword must contain only alphanumeric characters.");
         }

src/Hosting/PokManager.ServiceDefaults/Extensions.cs

@@ -110,7 +110,7 @@ public static WebApplication MapDefaultEndpoints(this WebApplication app)
     {
         // Health checks are enabled in all environments for deployment verification
         // In production, consider adding authentication or IP restrictions if needed
-        
+
         // All health checks must pass for app to be considered ready to accept traffic after starting
         app.MapHealthChecks(HealthEndpointPath);
 

src/Infrastructure/PokManager.Infrastructure.Docker/Models/DockerComposeConfig.cs

@@ -30,7 +30,7 @@ public class DockerComposeConfig
     public int RestartNoticeMinutes { get; set; }
     public string TimeZone { get; set; } = string.Empty;
     public string MemoryLimit { get; set; } = string.Empty;
-    
+
     /// <summary>
     /// Path to the docker-compose file
     /// </summary>

src/Infrastructure/PokManager.Infrastructure.Docker/Services/DiskBasedInstanceDiscoveryService.cs

@@ -1,7 +1,7 @@
+using Microsoft.Extensions.Logging;
 using PokManager.Application.Ports;
 using PokManager.Domain.Common;
 using PokManager.Infrastructure.Docker.Models;
-using Microsoft.Extensions.Logging;
 
 namespace PokManager.Infrastructure.Docker.Services;
 

src/Infrastructure/PokManager.Infrastructure.Docker/Services/DockerComposeParser.cs

@@ -34,18 +34,18 @@ public class DockerComposeParser
                 .Build();
 
             var doc = deserializer.Deserialize<Dictionary<string, object>>(yaml);
-            
+
             if (!doc.ContainsKey("services"))
                 return null;
 
             var services = (Dictionary<object, object>)doc["services"];
             var firstService = services.Values.FirstOrDefault();
-            
+
             if (firstService == null)
                 return null;
 
             var service = (Dictionary<object, object>)firstService;
-            
+
             var config = new DockerComposeConfig
             {
                 ConfigFilePath = filePath

src/Infrastructure/PokManager.Infrastructure.Docker/Services/DockerInstanceDiscoveryService.cs

@@ -30,7 +30,7 @@ public async Task<Result<IReadOnlyList<string>>> DiscoverInstancesAsync(Cancella
         try
         {
             var containers = await _dockerService.ListContainersAsync(cancellationToken);
-            
+
             // Extract instance IDs from container names (remove 'asa_' prefix)
             var instanceIds = containers
                 .Where(c => c.Name.StartsWith("asa_", StringComparison.OrdinalIgnoreCase))