Custom bulk action#176
Conversation
e78f209 to
51eb691
Compare
|
What I like: ability to add bulk action settings. What I don't like: separate implementations for each setting. Given that we just recently added a more general approach to query properties I would like to do the same for these settings. I therefore think a slightly different approach from yours is necessary. @blackshadev do you agree? @fedeisas in any case, thanks for bringing this idea and PR, it certainly can be a good improvement to Explorer! |
|
I agree with @Jeroen-G , I like the new ability. But not the implementation. Adding multiple If we have it wrong and it should be implemented with an interface on the model: I'd like to see the interface be called different And last but not least, there is one escaped mutation test, which we'd like to see solved in a test. I hope this doesn't de-motivate you, since we do like to see you and this functionality contributed to Explorer, just not in the way you implemented it. Or we are "missing" some extra information, why this is the best approach. |
If you have a multi-tenant system and know that the queries will always include a filter condition for a given tenant, you might want to instruct Elasticsearch to group the documents for the same tenant on the same shard.
This PR provides a
prepareIndexActionmethod to add metadata to the Bulk action.Similar to
prepare()I added a new interfaceJeroenG\Explorer\Application\BeIndexedto hold this new behavior.